Bug 55322

Summary: [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebKit QtAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, noam
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2011-02-27 10:09:38 PST
The QtWebKit bridge documentation is important to do anything non-trivial with QWebFrame::addToJavaScriptWindowObject(), the page should be referenced from there so people would find it more easily.
Attachments
Patch (1.70 KB, patch)
2011-02-27 10:14 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-02-27 10:14:43 PST
Created attachment 83977 [details] Patch
Andreas Kling
Comment 2 2011-02-27 10:15:45 PST
Comment on attachment 83977 [details] Patch Did you performance test this?
WebKit Commit Bot
Comment 3 2011-02-27 11:37:29 PST
The commit-queue encountered the following flaky tests while processing attachment 83977 [details]: animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2011-02-27 11:39:06 PST
Comment on attachment 83977 [details] Patch Clearing flags on attachment: 83977 Committed r79826: <http://trac.webkit.org/changeset/79826>
WebKit Commit Bot
Comment 5 2011-02-27 11:39:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.