Bug 55318

Summary: Crash logs aren't saved on Windows 7 when a relative --results-directory path is used (like on the test slaves)
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: sfalken
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 44135    
Attachments:
Description Flags
Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving mitz: review+

Adam Roben (:aroben)
Reported 2011-02-27 09:18:47 PST
Crash logs aren't saved on Windows 7 when a relative --results-directory path is used (like on the test slaves). Windows XP does not have this issue. The problem is due to a difference in how the post-mortem debugger is launched on these two OSes. Windows XP: The post-mortem debugger is a child process of the crashing process, and its working directory matches the crashing process's. Windows 7: The post-mortem debugger is a child process of WerFault.exe, and its working directory is c:\Windows\system32. We save crash logs to a location relative to $testResultsDirectory in old-run-webkit-tests. When a relative path is passed to --results-directory, the path to the crash log file ends up being relative, too. Since the post-mortem debugger's working directory is c:\Windows\system32, the crash log file path gets resolved against that path, rather than getting resolved against old-run-webkit-tests working directory.
Attachments
Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving (2.07 KB, patch)
2011-02-27 09:26 PST, Adam Roben (:aroben) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-02-27 09:26:37 PST
Created attachment 83975 [details] Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
Adam Roben (:aroben)
Comment 2 2011-02-27 09:30:25 PST
Committed r79819: <http://trac.webkit.org/changeset/79819>
Note You need to log in before you can comment on or make changes to this bug.