Bug 55303

Summary: [Qt] Use WTF ref counting for FontPlatformDataPrivate
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt, QtTriaged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Proposed patch kenneth: review+

Description Andreas Kling 2011-02-26 12:28:35 PST
FontPlatformDataPrivate currently has hand-rolled ref counting for some reason. We should use RefCounted/RefPtr instead.
Comment 1 Andreas Kling 2011-02-26 12:39:07 PST
Created attachment 83946 [details]
Proposed patch
Comment 2 Andreas Kling 2011-02-26 13:35:14 PST
Created attachment 83951 [details]
Proposed patch
Comment 3 Kenneth Rohde Christiansen 2011-02-27 04:46:50 PST
Comment on attachment 83951 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83951&action=review

Nice!

> Source/WebCore/platform/graphics/qt/FontPlatformData.h:101
> +            return 0;

Nice, fixing style as well :-)

> Source/WebCore/platform/graphics/qt/FontPlatformData.h:137
> +        // WebKit allows font size zero but QFont does not.

WebCore allows a font size of zero, but QFont does not.
Comment 4 Andreas Kling 2011-02-27 07:56:17 PST
Committed r79818: <http://trac.webkit.org/changeset/79818>