Bug 55303 - [Qt] Use WTF ref counting for FontPlatformDataPrivate
Summary: [Qt] Use WTF ref counting for FontPlatformDataPrivate
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: Qt, QtTriaged
Depends on:
Reported: 2011-02-26 12:28 PST by Andreas Kling
Modified: 2011-02-27 07:56 PST (History)
0 users

See Also:

Proposed patch (5.48 KB, patch)
2011-02-26 12:39 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Proposed patch (11.37 KB, patch)
2011-02-26 13:35 PST, Andreas Kling
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-02-26 12:28:35 PST
FontPlatformDataPrivate currently has hand-rolled ref counting for some reason. We should use RefCounted/RefPtr instead.
Comment 1 Andreas Kling 2011-02-26 12:39:07 PST
Created attachment 83946 [details]
Proposed patch
Comment 2 Andreas Kling 2011-02-26 13:35:14 PST
Created attachment 83951 [details]
Proposed patch
Comment 3 Kenneth Rohde Christiansen 2011-02-27 04:46:50 PST
Comment on attachment 83951 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83951&action=review


> Source/WebCore/platform/graphics/qt/FontPlatformData.h:101
> +            return 0;

Nice, fixing style as well :-)

> Source/WebCore/platform/graphics/qt/FontPlatformData.h:137
> +        // WebKit allows font size zero but QFont does not.

WebCore allows a font size of zero, but QFont does not.
Comment 4 Andreas Kling 2011-02-27 07:56:17 PST
Committed r79818: <http://trac.webkit.org/changeset/79818>