WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55303
[Qt] Use WTF ref counting for FontPlatformDataPrivate
https://bugs.webkit.org/show_bug.cgi?id=55303
Summary
[Qt] Use WTF ref counting for FontPlatformDataPrivate
Andreas Kling
Reported
2011-02-26 12:28:35 PST
FontPlatformDataPrivate currently has hand-rolled ref counting for some reason. We should use RefCounted/RefPtr instead.
Attachments
Proposed patch
(5.48 KB, patch)
2011-02-26 12:39 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Proposed patch
(11.37 KB, patch)
2011-02-26 13:35 PST
,
Andreas Kling
kenneth
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2011-02-26 12:39:07 PST
Created
attachment 83946
[details]
Proposed patch
Andreas Kling
Comment 2
2011-02-26 13:35:14 PST
Created
attachment 83951
[details]
Proposed patch
Kenneth Rohde Christiansen
Comment 3
2011-02-27 04:46:50 PST
Comment on
attachment 83951
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=83951&action=review
Nice!
> Source/WebCore/platform/graphics/qt/FontPlatformData.h:101 > + return 0;
Nice, fixing style as well :-)
> Source/WebCore/platform/graphics/qt/FontPlatformData.h:137 > + // WebKit allows font size zero but QFont does not.
WebCore allows a font size of zero, but QFont does not.
Andreas Kling
Comment 4
2011-02-27 07:56:17 PST
Committed
r79818
: <
http://trac.webkit.org/changeset/79818
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug