Bug 55288

Summary: [Qt] Fix the focus in MiniBrowser.
Product: WebKit Reporter: Yael <yael>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch.
kling: review+, kling: commit-queue-
Patch. none

Description Yael 2011-02-25 19:45:40 PST 
Currently, loading pages such as www.google.com show a caret blinking both in the address bar and in the search box.
This is really annoying :)
Comment 1 Yael 2011-02-25 19:50:58 PST 
Created attachment 83919 [details]
Patch.

Basic focus functionality.
Note that isVisible() is called before the view is created thus the extra check.
Comment 2 Andreas Kling 2011-02-26 05:32:15 PST 
Comment on attachment 83919 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=83919&action=review

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:168
> +    return view->isActive();

No null check for 'view'?

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:173
> +    return view->hasFocus();

No null check for 'view'?

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:178
> +    return view ? view->isVisible() : false;

return view && view->isVisible();
Comment 3 Andreas Kling 2011-02-26 05:33:05 PST 
(In reply to comment #1)
> Note that isVisible() is called before the view is created thus the extra check.

D'oh. Another case of I-went-straight-to-the-patch-review-interface.
Comment 4 Yael 2011-02-26 07:31:26 PST 
Created attachment 83941 [details]
Patch.
Comment 5 WebKit Commit Bot 2011-02-26 07:53:18 PST 
Comment on attachment 83941 [details]
Patch.

Clearing flags on attachment: 83941

Committed r79791: <http://trac.webkit.org/changeset/79791>
Comment 6 WebKit Commit Bot 2011-02-26 07:53:22 PST 
All reviewed patches have been landed.  Closing bug.