Bug 55288 – [Qt] Fix the focus in MiniBrowser.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Yael]

Currently, loading pages such as www.google.com show a caret blinking both in the address bar and in the search box.
This is really annoying :)

[Yael]

Created attachment 83919 [details]
Patch.

Basic focus functionality.
Note that isVisible() is called before the view is created thus the extra check.

[Andreas Kling]

Comment on attachment 83919 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=83919&action=review

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:168
> +    return view->isActive();

No null check for 'view'?

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:173
> +    return view->hasFocus();

No null check for 'view'?

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:178
> +    return view ? view->isVisible() : false;

return view && view->isVisible();

[Andreas Kling]

(In reply to comment #1)
> Note that isVisible() is called before the view is created thus the extra check.

D'oh. Another case of I-went-straight-to-the-patch-review-interface.

[Yael]

Created attachment 83941 [details]
Patch.

[WebKit Commit Bot]

Comment on attachment 83941 [details]
Patch.

Clearing flags on attachment: 83941

Committed r79791: <http://trac.webkit.org/changeset/79791>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.