Bug 55278

Summary: V8 IDL code generator shouldn't emit an #include line for DOMString.
Product: WebKit Reporter: Daniel Cheng <dcheng>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Daniel Cheng 2011-02-25 17:36:47 PST 
V8 IDL code generator shouldn't emit an #include line for DOMString.
Comment 1 Daniel Cheng 2011-02-25 17:39:12 PST 
Created attachment 83905 [details]
Patch
Comment 2 Daniel Cheng 2011-02-25 17:40:57 PST 
I notice there's a test subdir, but I'm not sure how to run the tests contains within. Any tips?
Comment 3 Darin Adler 2011-02-25 17:40:58 PST 
Comment on attachment 83905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83905&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests, since I haven't figured out how to run them (OOPS!).

You are supposed to runt them by typing "run-bindings-tests" at the command line. I tried just now and they seem to be broken.
Comment 4 Daniel Cheng 2011-02-28 18:33:21 PST 
Fixing the code generator as part of https://bugs.webkit.org/show_bug.cgi?id=55115. Landing this patch by itself wouldn't do too much, and the IDL generator tests are somewhat stale at the moment.
Comment 5 Eric Seidel (no email) 2011-03-08 09:46:40 PST 
Comment on attachment 83905 [details]
Patch

Cleared review? from attachment 83905 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).