Summary: | [EFL] API for application cache database directory path moved from ewk_view to ewk_setting because of wrong logic | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lukasz Slachciak <l.slachciak> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED DUPLICATE | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, leandro, ryuan.choi, tonikitoo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Lukasz Slachciak
2011-02-25 13:57:27 PST
Created attachment 83871 [details]
API for application cache database directory
Comment on attachment 83871 [details] API for application cache database directory View in context: https://bugs.webkit.org/attachment.cgi?id=83871&action=review > Source/WebKit/efl/ChangeLog:5 > + API for application cache database directory path moved from ewk_view to ewk_settings Please sync with bug title. > Source/WebKit/efl/ChangeLog:6 > + Please add bug url > Source/WebKit/efl/ewk/ewk_settings.cpp:147 > + eina_stringshare_replace(&_ewk_application_cache_database_path, path); We should prepare that the "OFFLINE_WEB_APPLICATIONS" is disabled, For example, #else return; #endif > Source/WebKit/efl/ewk/ewk_settings.cpp:164 > + return _ewk_application_cache_database_path; Same with above. Created attachment 83931 [details]
API for application cache database directory
Thank you Gyuyoung for comments. I followed them. I am sorry about late answer. It looks duplicated with https://bugs.webkit.org/show_bug.cgi?id=52139 *** This bug has been marked as a duplicate of bug 52139 *** Thank you Ryuan for comment. I resolved this bug as duplicate, but please take care about adding #if ENABLE(OFFLINE_WEB_APPLICATIONS) in your patch Comment on attachment 83931 [details] API for application cache database directory Cleared review? from attachment 83931 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). |