Bug 55229 – REGRESSION (r66062) - inputElement.innerText = "" throws

• Component: DOM
• Status: RESOLVED CONFIGURATION CHANGED

[Brady Eidson]

REGRESSION (r66062) - set(Inner/Outer)Text on many types of elements throws an exception, and they didn't before.

Link to the change:
http://trac.webkit.org/changeset/66057
Link to the original bug:
https://bugs.webkit.org/show_bug.cgi?id=44626

ChangeLog says "this is just moving code and should have no functional change."

But by replacing the usage of "HTMLElement::endTagRequirement()" with "HTMLElement::ieForbidsInsertHTML()" in 3 key places in HTMLElement, it had functional change.

Before this change, HTMLElement::deprecatedCreateContextualFragment would only fail to return a fragment for <wbr> elements.  Now it fails for ~20 tag names listed in HTMLElement::ieForbidsInsertHTML()

Before this change, HTMLElement::setInnerText and HTMLElement::setOuterText only threw exceptions for 10 tag names they knew about, and <wbr>.
Now they throw exceptions for the 10 tag names they knew about, and the ~20 listed in HTMLElement::ieForbidsInsertHTML()

This broke compatibility with other browsers like Firefox and Opera.  It also *broke* compatibility with IE while purporting to match IE's rules, as noted in the FIXME comment in ieForbidsInsertHTML()

Test case coming soon...

[Brady Eidson]

Created attachment 83852 [details]
Test derived from

This is a test derived from a real world affected site my.schedulemaster.com

Sadly the real site requires logins and no pilot would be likely to hand theirs out (I sure am not).

But let's just say that a lot of pilots really like WebKit based browsers.  :)

[Brady Eidson]

Created attachment 83853 [details]
Better test with explanatory text

[Brady Eidson]

<rdar://problem/9055014>

[Eric Seidel (no email)]

innerText isn't spec'd, but the change in question was not supposed to change behavior.  Will investigate what changed.

[Eric Seidel (no email)]

Firefox doesn't support innerText, so the testcase is misleading.  I suspect the site in question follows a different codepath for firefox.

[Eric Seidel (no email)]

Has this shipped in a Safari?  I'm testing with Version 5.0.3 (6533.19.4) and I see the same exception as top of tree.

[Brady Eidson]

(In reply to comment #6)
> Has this shipped in a Safari?  I'm testing with Version 5.0.3 (6533.19.4) and I see the same exception as top of tree.

Hmmmm.  Admittedly and amusingly I'd never tried with Safari 5.0.3, I only tried with ToT and the patch partially rolled out.  Maybe "partially" rolled out invented the state I was expecting to see.

Will explore more when I'm around code on Monday.

[Ahmad Saleem]

I am unable to reproduce this bug in Safari 15.6 on macOS 12.5 and it does not throw any exception in Console or no dialog box. It was similar to Firefox Nightly 105 and Chrome Canary 106.

Further, Safari also pass all test cases here:

https://wpt.fyi/results/html/dom/elements/the-innertext-and-outertext-properties/innertext-setter.html?label=master&label=experimental&aligned&view=subtest&q=innerText

I am going to mark this as "RESOLVED CONFIGURATION CHANGED" but if you are able to reproduce then please reopen this. Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/98406179>