Bug 55227

Summary: old-run-webkit-tests falsely claims to be saving crash logs on Windows Vista/7
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: ddkilzer, sfalken
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Description Flags
Double-check that modifying the registry worked darin: review+

Description Adam Roben (:aroben) 2011-02-25 09:48:31 PST
old-run-webkit-tests modifies the registry to configure a post-mortem debugger to save crash logs. This doesn't work on Windows Vista/7 because you need administrator privileges to modify the registry. But old-run-webkit-tests thinks it successfully modified the registry and thus claims to be saving crash logs.

Actually making crash log saving work is covered by bug 44135. But in the meantime we should make old-run-webkit-tests stop lying.
Comment 1 Adam Roben (:aroben) 2011-02-25 09:53:11 PST
Created attachment 83827 [details]
Double-check that modifying the registry worked
Comment 2 Adam Roben (:aroben) 2011-02-25 10:50:31 PST
Committed r79698: <http://trac.webkit.org/changeset/79698>