Bug 55224 – old-run-webkit-test's Windows registry code is ugly

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

old-run-webkit-test's Windows registry code is ugly

[Adam Roben (:aroben)]

Created attachment 83823 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 83823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83823&action=review

r=me

> Tools/Scripts/old-run-webkit-tests:2607
> +    my ($valueName) = @_;

Maybe $key instead of $valueName?

> Tools/Scripts/old-run-webkit-tests:2614
> +    my ($valueName, $data) = @_;

Maybe ($key, $value) instead of ($valueName, $data)?

[Adam Roben (:aroben)]

Comment on attachment 83823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83823&action=review

>> Tools/Scripts/old-run-webkit-tests:2607
>> +    my ($valueName) = @_;
> 
> Maybe $key instead of $valueName?

Unfortunately, "key" has a different meaning in registry-speak. (The registry is a tree. Leaf nodes are called "values", and a value has a name, a type, and some data associated with it. Non-leaf nodes are called "keys", and just have a name.)

>> Tools/Scripts/old-run-webkit-tests:2614
>> +    my ($valueName, $data) = @_;
> 
> Maybe ($key, $value) instead of ($valueName, $data)?

I changed $data to $string, but left $valueName alone.

[Adam Roben (:aroben)]

Committed r79696: <http://trac.webkit.org/changeset/79696>