Bug 55214

Summary:

[Qt]tst_QDeclarativeWebView - 8 test cases fail

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Alexis Menard (darktears) <menard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch to fix the script that launch the tests :).	none
After the previous patch there is still two failures.	kling: review-
Comments taken into account	none

Csaba Osztrogonác

Reported 2011-02-25 05:50:27 PST

********* Start testing of tst_QDeclarativeWebView ********* tst_QDeclarativeWebView introduced in http://trac.webkit.org/changeset/79672 and 8 test cases fail on Qt Linux Release buildbot: Config: Using QTest library 4.7.1, Qt 4.7.1 PASS : tst_QDeclarativeWebView::initTestCase() FAIL! : tst_QDeclarativeWebView::preferredWidthTest() '!component.isError()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(77)] QWARN : tst_QDeclarativeWebView::preferredWidthTest() QDeclarativeComponent: Component is not ready FAIL! : tst_QDeclarativeWebView::preferredWidthTest() 'wv' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(39)] FAIL! : tst_QDeclarativeWebView::preferredHeightTest() '!component.isError()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(77)] QWARN : tst_QDeclarativeWebView::preferredHeightTest() QDeclarativeComponent: Component is not ready FAIL! : tst_QDeclarativeWebView::preferredHeightTest() 'wv' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(49)] FAIL! : tst_QDeclarativeWebView::preferredWidthDefaultTest() '!component.isError()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(77)] QWARN : tst_QDeclarativeWebView::preferredWidthDefaultTest() QDeclarativeComponent: Component is not ready FAIL! : tst_QDeclarativeWebView::preferredWidthDefaultTest() 'wv' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(59)] FAIL! : tst_QDeclarativeWebView::preferredHeightDefaultTest() '!component.isError()' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(77)] QWARN : tst_QDeclarativeWebView::preferredHeightDefaultTest() QDeclarativeComponent: Component is not ready FAIL! : tst_QDeclarativeWebView::preferredHeightDefaultTest() 'wv' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(69)] PASS : tst_QDeclarativeWebView::cleanupTestCase() Totals: 2 passed, 8 failed, 0 skipped ********* Finished testing of tst_QDeclarativeWebView *********

Attachments
Patch to fix the script that launch the tests :). (1.13 KB, patch) 2011-02-28 05:57 PST, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
After the previous patch there is still two failures. (6.28 KB, patch) 2011-02-28 08:24 PST, Alexis Menard (darktears)	kling: review-	Details Formatted Diff Diff
Comments taken into account (6.24 KB, patch) 2011-02-28 08:31 PST, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexis Menard (darktears)

Comment 1 2011-02-28 05:57:52 PST

Created attachment 84046 [details] Patch to fix the script that launch the tests :).

Csaba Osztrogonác

Comment 2 2011-02-28 05:59:33 PST

Comment on attachment 84046 [details] Patch to fix the script that launch the tests :). Thx, r=me.

WebKit Commit Bot

Comment 3 2011-02-28 06:55:59 PST

Comment on attachment 84046 [details] Patch to fix the script that launch the tests :). Clearing flags on attachment: 84046 Committed r79859: <http://trac.webkit.org/changeset/79859>

WebKit Commit Bot

Comment 4 2011-02-28 06:56:04 PST

All reviewed patches have been landed. Closing bug.

Alexis Menard (darktears)

Comment 5 2011-02-28 08:24:13 PST

Created attachment 84064 [details] After the previous patch there is still two failures. Fix the auto-tests.

Andreas Kling

Comment 6 2011-02-28 08:29:00 PST

Comment on attachment 84064 [details] After the previous patch there is still two failures. View in context: https://bugs.webkit.org/attachment.cgi?id=84064&action=review Looks good, just a tiny thing: > Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:60 > + view.page()->mainFrame()->load(QUrl("qrc:///resources/sample.html")); view.load() > Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:74 > + view.page()->mainFrame()->load(QUrl("qrc:///resources/sample.html")); Ditto.

Alexis Menard (darktears)

Comment 7 2011-02-28 08:31:39 PST

Created attachment 84066 [details] Comments taken into account

Andreas Kling

Comment 8 2011-02-28 08:32:02 PST

Comment on attachment 84066 [details] Comments taken into account r=me!

Csaba Osztrogonác

Comment 9 2011-02-28 12:13:18 PST

Comment on attachment 84066 [details] Comments taken into account Landed in http://trac.webkit.org/changeset/79894

Note You need to log in before you can comment on or make changes to this bug.