Bug 55214 – [Qt]tst_QDeclarativeWebView - 8 test cases fail

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

********* Start testing of tst_QDeclarativeWebView *********
tst_QDeclarativeWebView introduced in http://trac.webkit.org/changeset/79672
and 8 test cases fail on Qt Linux Release buildbot:

Config: Using QTest library 4.7.1, Qt 4.7.1
PASS   : tst_QDeclarativeWebView::initTestCase()
FAIL!  : tst_QDeclarativeWebView::preferredWidthTest() '!component.isError()' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(77)]
QWARN  : tst_QDeclarativeWebView::preferredWidthTest() QDeclarativeComponent: Component is not ready
FAIL!  : tst_QDeclarativeWebView::preferredWidthTest() 'wv' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(39)]
FAIL!  : tst_QDeclarativeWebView::preferredHeightTest() '!component.isError()' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(77)]
QWARN  : tst_QDeclarativeWebView::preferredHeightTest() QDeclarativeComponent: Component is not ready
FAIL!  : tst_QDeclarativeWebView::preferredHeightTest() 'wv' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(49)]
FAIL!  : tst_QDeclarativeWebView::preferredWidthDefaultTest() '!component.isError()' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(77)]
QWARN  : tst_QDeclarativeWebView::preferredWidthDefaultTest() QDeclarativeComponent: Component is not ready
FAIL!  : tst_QDeclarativeWebView::preferredWidthDefaultTest() 'wv' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(59)]
FAIL!  : tst_QDeclarativeWebView::preferredHeightDefaultTest() '!component.isError()' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(77)]
QWARN  : tst_QDeclarativeWebView::preferredHeightDefaultTest() QDeclarativeComponent: Component is not ready
FAIL!  : tst_QDeclarativeWebView::preferredHeightDefaultTest() 'wv' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp(69)]
PASS   : tst_QDeclarativeWebView::cleanupTestCase()
Totals: 2 passed, 8 failed, 0 skipped
********* Finished testing of tst_QDeclarativeWebView *********

[Alexis Menard (darktears)]

Created attachment 84046 [details]
Patch to fix the script that launch the tests :).

[Csaba Osztrogonác]

Comment on attachment 84046 [details]
Patch to fix the script that launch the tests :).

Thx, r=me.

[WebKit Commit Bot]

Comment on attachment 84046 [details]
Patch to fix the script that launch the tests :).

Clearing flags on attachment: 84046

Committed r79859: <http://trac.webkit.org/changeset/79859>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexis Menard (darktears)]

Created attachment 84064 [details]
After the previous patch there is still two failures.

Fix the auto-tests.

[Andreas Kling]

Comment on attachment 84064 [details]
After the previous patch there is still two failures.

View in context: https://bugs.webkit.org/attachment.cgi?id=84064&action=review

Looks good, just a tiny thing:

> Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:60
> +    view.page()->mainFrame()->load(QUrl("qrc:///resources/sample.html"));

view.load()

> Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:74
> +    view.page()->mainFrame()->load(QUrl("qrc:///resources/sample.html"));

Ditto.

[Alexis Menard (darktears)]

Created attachment 84066 [details]
Comments taken into account

[Andreas Kling]

Comment on attachment 84066 [details]
Comments taken into account

r=me!

[Csaba Osztrogonác]

Comment on attachment 84066 [details]
Comments taken into account

Landed in http://trac.webkit.org/changeset/79894