| Summary: | [chromium] Don't clear existing files if file chooser is canceled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sailesh Agrawal <sail> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, brettw, commit-queue, eric, tkent, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Sailesh Agrawal
2011-02-24 18:04:22 PST
Created attachment 83757 [details]
Patch
(In reply to comment #0) > Don't clear existing files if file chooser is canceled Why? Without the current behavior, users can't clear the selected file. Though the current behavior is not compatible with Safari, I think it's intentional. (In reply to comment #2) > (In reply to comment #0) > > Don't clear existing files if file chooser is canceled > > Why? Without the current behavior, users can't clear the selected file. This is a usability bug. Cancel should always abort the current operation. If we need a way to clear the selected file then we should add a separate way to do that. > Though the current behavior is not compatible with Safari, I think it's intentional. It's not about being compatible with Safari. I just tried Firefox and it does the same thing as Safari too. Comment on attachment 83757 [details]
Patch
Agreed. This seems like the right fix to me. Cancelling a dialog should leave existing state unchanged.
Comment on attachment 83757 [details] Patch Clearing flags on attachment: 83757 Committed r82914: <http://trac.webkit.org/changeset/82914> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/82914 might have broken GTK Linux 32-bit Debug |