Bug 55200

Summary:

[chromium] Don't clear existing files if file chooser is canceled

Product:

WebKit

Reporter:

Sailesh Agrawal <sail>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, brettw, commit-queue, eric, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Sailesh Agrawal

Reported 2011-02-24 18:04:22 PST

Don't clear existing files if file chooser is canceled

Attachments
Patch (1.32 KB, patch) 2011-02-24 18:05 PST, Sailesh Agrawal	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sailesh Agrawal

Comment 1 2011-02-24 18:05:34 PST

Created attachment 83757 [details] Patch

Kent Tamura

Comment 2 2011-02-26 06:43:44 PST

(In reply to comment #0) > Don't clear existing files if file chooser is canceled Why? Without the current behavior, users can't clear the selected file. Though the current behavior is not compatible with Safari, I think it's intentional.

Sailesh Agrawal

Comment 3 2011-02-27 08:28:12 PST

(In reply to comment #2) > (In reply to comment #0) > > Don't clear existing files if file chooser is canceled > > Why? Without the current behavior, users can't clear the selected file. This is a usability bug. Cancel should always abort the current operation. If we need a way to clear the selected file then we should add a separate way to do that. > Though the current behavior is not compatible with Safari, I think it's intentional. It's not about being compatible with Safari. I just tried Firefox and it does the same thing as Safari too.

Darin Fisher (:fishd, Google)

Comment 4 2011-04-04 21:20:11 PDT

Comment on attachment 83757 [details] Patch Agreed. This seems like the right fix to me. Cancelling a dialog should leave existing state unchanged.

WebKit Commit Bot

Comment 5 2011-04-05 02:07:03 PDT

Comment on attachment 83757 [details] Patch Clearing flags on attachment: 83757 Committed r82914: <http://trac.webkit.org/changeset/82914>

WebKit Commit Bot

Comment 6 2011-04-05 02:07:08 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 7 2011-04-05 03:50:36 PDT

http://trac.webkit.org/changeset/82914 might have broken GTK Linux 32-bit Debug

Note You need to log in before you can comment on or make changes to this bug.