Bug 55186

Summary: RenderBoxModelObject::paintBoxShadow should bail earlier
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Simon Fraser (smfr)
Reported 2011-02-24 14:50:34 PST
RenderBoxModelObject::paintBoxShadow() does some work before it looks to see if there are any shadows. It should just bail earlier.
Attachments
Patch (4.70 KB, patch)
2011-02-24 15:57 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (3.91 KB, patch)
2011-02-24 16:16 PST, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-02-24 15:57:20 PST
Created attachment 83738 [details] Patch
mitz
Comment 2 2011-02-24 16:02:38 PST
(In reply to comment #0) > RenderBoxModelObject::paintBoxShadow() does some work before it looks to see if there are any shadows. It should just bail earlier. Sounds like a good idea. (In reply to comment #1) > Created an attachment (id=83738) [details] > Patch Looks like a different idea. Why not return early from paintBoxShadow()?
Simon Fraser (smfr)
Comment 3 2011-02-24 16:16:13 PST
Created attachment 83741 [details] Patch
Simon Fraser (smfr)
Comment 4 2011-02-24 20:48:49 PST
http://trac.webkit.org/changeset/79647
Note You need to log in before you can comment on or make changes to this bug.