Bug 55149

Summary:

[Qt] Revert the support for QNAM affined to a different thread.

Product:

WebKit

Reporter:

Jocelyn Turcotte <jturcotte>

Component:

Page Loading

Assignee:

Jocelyn Turcotte <jturcotte>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kenneth, kling, laszlo.gombos

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	kling: review+

Jocelyn Turcotte

Reported 2011-02-24 08:25:36 PST

Qt 4.8 will have QNAM use its own thread internally by default, no need to keep this complexity in WebKit. This mainly reverts: http://trac.webkit.org/changeset/73710 http://trac.webkit.org/changeset/73712

Attachments
Patch (53.34 KB, patch) 2011-02-24 09:22 PST, Jocelyn Turcotte	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jocelyn Turcotte

Comment 1 2011-02-24 09:22:10 PST

Created attachment 83670 [details] Patch

Kenneth Rohde Christiansen

Comment 2 2011-02-24 09:29:33 PST

Maybe we should do this after 4.8 has actually been released?

Andreas Kling

Comment 3 2011-02-24 09:44:03 PST

(In reply to comment #2) > Maybe we should do this after 4.8 has actually been released? There's no point in waiting. We're not going to release anything based on trunk before Qt 4.8 anyway, and that will include the threaded HTTP backend for QNAM.

Jocelyn Turcotte

Comment 4 2011-02-25 03:09:22 PST

Committed r79668: <http://trac.webkit.org/changeset/79668>

Laszlo Gombos

Comment 5 2011-02-25 05:40:23 PST

I'm with Kenneth on this one. QtNetwork 4.8 is not release yet, so all the benchmarking etc. we're doing for the trunk is impacted.

Andreas Kling

Comment 6 2011-02-25 05:51:40 PST

(In reply to comment #5) > I'm with Kenneth on this one. > > QtNetwork 4.8 is not release yet, so all the benchmarking etc. we're doing for the trunk is impacted. What is the relevance of those benchmarks? We already know that the next release based on trunk is going to be with Qt 4.8, and it will have threaded HTTP in-Qt.

Jocelyn Turcotte

Comment 7 2011-02-25 06:00:49 PST

(In reply to comment #5) > I'm with Kenneth on this one. > > QtNetwork 4.8 is not release yet, so all the benchmarking etc. we're doing for the trunk is impacted. It's better to at least get this in *for* 4.8. We could wait and do it in the QtWebKit 2.2 branch and merge it in trunk after. However it would make merging any network work harder between trunk and the branch. Were you spawning you benchmark QNAM in a secondary thread? AFAIK, only QtTestBrowser was currently doing it by default, other QtWebKit apps shouldn't feel any regression from this revert patch.

Note You need to log in before you can comment on or make changes to this bug.