Bug 55147

Summary: Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
Product: WebKit Reporter: Yi Shen <max.hong.shen>
Component: MediaAssignee: Yi Shen <max.hong.shen>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue, eric.carlson, hui_huang, nancy.piedra
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
first try
none
updated with eric's suggestion none

Yi Shen
Reported 2011-02-24 08:06:29 PST
Discussed this issue with eric carlson, and we think when HTMLMediaElement::mediaPlayerVolumeChanged gets callback, a volumechangeEvent event should be fired if the volume gets changed.
Attachments
first try (1.93 KB, patch)
2011-02-24 08:20 PST, Yi Shen 		no flags
DetailsFormatted DiffDiff
updated with eric's suggestion (2.04 KB, patch)
2011-02-24 09:11 PST, Yi Shen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yi Shen
Comment 1 2011-02-24 08:20:44 PST
Created attachment 83660 [details] first try
Eric Carlson
Comment 2 2011-02-24 08:44:36 PST
Comment on attachment 83660 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=83660&action=review > Source/WebCore/ChangeLog:16 > + (WebCore::HTMLMediaElement::setMuted): > + (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): > + I would really prefer to have comments here about what changed in each function.
Yi Shen
Comment 3 2011-02-24 09:11:00 PST
Created attachment 83668 [details] updated with eric's suggestion Thanks for reviewing it, eric :)
Eric Carlson
Comment 4 2011-02-24 10:13:32 PST
Comment on attachment 83668 [details] updated with eric's suggestion Thanks!
WebKit Commit Bot
Comment 5 2011-02-26 01:03:50 PST
Comment on attachment 83668 [details] updated with eric's suggestion Clearing flags on attachment: 83668 Committed r79768: <http://trac.webkit.org/changeset/79768>
WebKit Commit Bot
Comment 6 2011-02-26 01:03:55 PST
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 7 2011-02-28 14:04:20 PST
Revision r79768 cherry-picked into qtwebkit-2.1.x with commit 847d993 <http://gitorious.org/webkit/qtwebkit/commit/847d993>
Note You need to log in before you can comment on or make changes to this bug.