Summary: | Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yi Shen <max.hong.shen> | ||||||
Component: | Media | Assignee: | Yi Shen <max.hong.shen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ademar, commit-queue, eric.carlson, hui_huang, nancy.piedra | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Yi Shen
2011-02-24 08:06:29 PST
Created attachment 83660 [details]
first try
Comment on attachment 83660 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=83660&action=review > Source/WebCore/ChangeLog:16 > + (WebCore::HTMLMediaElement::setMuted): > + (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): > + I would really prefer to have comments here about what changed in each function. Created attachment 83668 [details]
updated with eric's suggestion
Thanks for reviewing it, eric :)
Comment on attachment 83668 [details]
updated with eric's suggestion
Thanks!
Comment on attachment 83668 [details] updated with eric's suggestion Clearing flags on attachment: 83668 Committed r79768: <http://trac.webkit.org/changeset/79768> All reviewed patches have been landed. Closing bug. Revision r79768 cherry-picked into qtwebkit-2.1.x with commit 847d993 <http://gitorious.org/webkit/qtwebkit/commit/847d993> |