Bug 55134

Summary: [chromium] WebFrameImpl::m_totalMatchCount should be an int
Product: WebKit Reporter: John Mellor <johnme>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

John Mellor
Reported 2011-02-24 05:08:02 PST
[chromium] WebFrameImpl::m_totalMatchCount should be an int
Attachments
Patch (1.47 KB, patch)
2011-02-24 05:09 PST, John Mellor 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Mellor
Comment 1 2011-02-24 05:09:48 PST
Created attachment 83637 [details] Patch
Benjamin Poulain
Comment 2 2011-02-24 06:45:24 PST
No test possible?
John Mellor
Comment 3 2011-02-24 06:57:29 PST
This is just a trivial cleanup - the variable is documented as sometimes being -1, and is indeed initialized to -1 by the constructor, so shouldn't be using an unsigned type. In practice this won't change any behavior as the code happens to never depend on the signedness, hence it would be tricky to test.
John Mellor
Comment 4 2011-02-24 09:53:10 PST
Comment on attachment 83637 [details] Patch Thanks for the review. Could someone add this to the commit queue please?
Eric Seidel (no email)
Comment 5 2011-02-24 13:38:51 PST
Comment on attachment 83637 [details] Patch How do we test this?
Steve Block
Comment 6 2011-02-25 03:20:47 PST
> How do we test this? As John suggested, this is a trivial fix and the current behaviour is OK, so I don't think it's valuable to try to craft a regression test.
WebKit Commit Bot
Comment 7 2011-02-26 00:59:54 PST
Comment on attachment 83637 [details] Patch Clearing flags on attachment: 83637 Committed r79767: <http://trac.webkit.org/changeset/79767>
WebKit Commit Bot
Comment 8 2011-02-26 00:59:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.