Summary: | French (fr) sorting does not use 'backward' rule any more with ICU 4.6 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jungshik Shin <jshin> | ||||||
Component: | New Bugs | Assignee: | Jungshik Shin <jshin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, morrita, tony | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Jungshik Shin
2011-02-24 00:46:59 PST
Thank you for filing this! I've also filed Bug 55118 so Could you close it after fix this? *** Bug 55118 has been marked as a duplicate of this bug. *** Created attachment 83903 [details]
add chromium-specific expectation file
Created attachment 83904 [details]
same as above but a diff from the main expectation to be made clear using 'svn cp'
Should there also be an updated to test_expectations.txt? Comment on attachment 83904 [details] same as above but a diff from the main expectation to be made clear using 'svn cp' Rejecting attachment 83904 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: ebkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 2 Parsed 3 diffs from patch file(s). cp: fast/xsl/sort-locale-expected.txt: No such file or directory Failed to copy fast/xsl/sort-locale-expected.txt platform/chromium/fast/xsl/sort-locale-expected.txt. at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 427. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 2 Full output: http://queues.webkit.org/results/8070423 (In reply to comment #6) > Parsed 3 diffs from patch file(s). > cp: fast/xsl/sort-locale-expected.txt: No such file or directory > Failed to copy fast/xsl/sort-locale-expected.txt platform/chromium/fast/xsl/sort-locale-expected.txt. at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 427. > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 2 > > Full output: http://queues.webkit.org/results/8070423 The diff around the copy looks weird (it's relative to a different path than the other 2 files). Thank you for the review. The patch creating script does something strange in this case. Anyway, I manually landed the patch with the correct path. ( http://trac.webkit.org/changeset/79912 ). Later, I'll update test_expectations.txt as well. Thank you for the review. The patch creating script does something strange in this case. Anyway, I manually landed the patch with the correct path ( http://trac.webkit.org/changeset/79912 ). I forgot |