| Summary: | WebCursorInfo needs to match enums in platform/Cursor.h | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Avi Drissman <avi> | ||||||||
| Component: | Platform | Assignee: | Avi Drissman <avi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, commit-queue, dglazkov, eric, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 83571 [details]
Patch for missing values
Comment on attachment 83571 [details]
Patch for missing values
R=me
Attachment 83571 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7986260 Created attachment 83581 [details]
Updated version; adds checks to keep three enum lists from getting out of sync again.
Attachment 83581 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7981236 Comment on attachment 83581 [details] Updated version; adds checks to keep three enum lists from getting out of sync again. View in context: https://bugs.webkit.org/attachment.cgi?id=83581&action=review OK. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This shoudl be replaced by either a list of tests or explainaion why testing is impossible. Comment on attachment 83581 [details]
Updated version; adds checks to keep three enum lists from getting out of sync again.
cq would fail,a nd cr-linux is borked anyway.
This is temporarily blocked by some issues on the Chromium side; will fix today. There is no functional code being added, just enums. Tests are being added: a list of compile asserts that everything matches up so that this won't happen again. Created attachment 84056 [details]
Try again. Clarified ChangeLog, though no code change.
The dependency on the Chromium side was fixed; this should pass all trybots.
Comment on attachment 84056 [details]
Try again. Clarified ChangeLog, though no code change.
Looks good.
Comment on attachment 84056 [details] Try again. Clarified ChangeLog, though no code change. Clearing flags on attachment: 84056 Committed r79942: <http://trac.webkit.org/changeset/79942> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/79942 might have broken Qt Linux Release The following tests are not passing: fast/events/tabindex-focus-blur-all.html fast/frames/iframe-plugin-load-remove-document-crash.html fast/frames/sandboxed-iframe-attribute-parsing.html fast/layers/clip-rects-transformed.html fast/replaced/object-with-non-empty-classid-triggers-fallback.html plugins/createScriptableObject-before-start.html plugins/destroy-on-setwindow.html plugins/destroy-plugin-from-callback.html plugins/destroy-stream-twice.html plugins/document-open.html plugins/evaluate-js-after-removing-plugin-element.html plugins/get-file-url.html plugins/get-url-that-the-resource-load-delegate-will-disallow.html plugins/get-url-with-javascript-destroying-plugin.html plugins/geturl-replace-query.html plugins/geturlnotify-during-document-teardown.html plugins/instance-available-before-stylesheets-loaded-object.html plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html plugins/js-from-destroy.html (In reply to comment #13) > http://trac.webkit.org/changeset/79942 might have broken Qt Linux Release > The following tests are not passing: Huh? All the patch did was add enums to platform/chromium. |
In WebKit/chromium/src/WebCursorInfo.cpp: WebCursorInfo::WebCursorInfo(const Cursor& cursor) { type = static_cast<Type>(cursor.impl().type()); yet WebCursorInfo::Type has two fewer items in the enum than Cursor::Type. This needs to be fixed.