Bug 55087

Summary: webkitpy.layout_tests.layout_package.manager_worker_broker_unittest.FunctionTests.test_get__processes sometimes fails on Windows
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, mihaip, ojan, rakuco, tony, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/9679/steps/webkitpy-test/logs/stdio
Attachments:
Description Flags
Patch none

Adam Roben (:aroben)
Reported 2011-02-23 14:50:19 PST
webkitpy.layout_tests.layout_package.manager_worker_broker_unittest.FunctionTests.test_get__processes is sometimes failing on Windows. For example: Did not fail: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/9673 Did fail: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/9679 So far I've only seen it fail on apple-windows-5, which is running Python 2.6.5. I believe apple-windows-6 is running Python 2.5.x.
Attachments
Patch (1.64 KB, patch)
2011-02-28 16:58 PST, Dirk Pranke
no flags
Dirk Pranke
Comment 1 2011-02-23 17:40:44 PST
Hm. That test is showing python-level failures in the "multiprocessing" module, which is only available under Python 2.6. So that test won't run (or fail) under 2.5. We'll have to watch it to see how flaky it is ...
Adam Roben (:aroben)
Comment 3 2011-02-24 07:33:29 PST
More failures: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/9662 http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/9671 So it failed 4 times from build 9662 to build 9691, inclusive. That's once every 7 builds or so.
Adam Roben (:aroben)
Comment 4 2011-02-27 10:18:00 PST
Adam Roben (:aroben)
Comment 5 2011-02-28 08:07:19 PST
We've been seeing cases where lots of python processes are left around on the bots. I wonder if this bug is the/a cause of that?
Dirk Pranke
Comment 6 2011-02-28 13:08:36 PST
(In reply to comment #5) > We've been seeing cases where lots of python processes are left around on the bots. I wonder if this bug is the/a cause of that? It's quite possible. When I briefly had the multiprocessing module enabled for new-run-webkit-tests, we also seemed to see a bunch of processes lying around. I think I'll disable this test for now until I can do some more testing on Windows and see if there are bugs I can reproduce/triage/fix.
Dirk Pranke
Comment 7 2011-02-28 16:25:45 PST
Assigning to myself and skipping for now until I can triage it further.
Dirk Pranke
Comment 8 2011-02-28 16:58:49 PST
Dirk Pranke
Comment 9 2011-02-28 18:34:20 PST
I don't like skipping tests ... anyone have any ideas before I disable it?
Adam Roben (:aroben)
Comment 10 2011-03-01 05:55:49 PST
Skipped the test on Windows to get the bots green Committed r79993: <http://trac.webkit.org/changeset/79993>
WebKit Review Bot
Comment 11 2011-03-01 08:39:16 PST
http://trac.webkit.org/changeset/79993 might have broken GTK Linux 32-bit Debug
Dirk Pranke
Comment 12 2011-03-02 18:17:54 PST
clearing ownership now that I've disabled the bug, in the off chance that someone else wants to take this.
Eric Seidel (no email)
Comment 13 2011-06-18 13:43:00 PDT
Attachment 84152 [details] was posted by a committer and has review+, assigning to Dirk Pranke for commit.
Dirk Pranke
Comment 14 2011-06-20 12:19:36 PDT
It looks like aroben landed this in r79993. Closing.
Raphael Kubo da Costa (:rakuco)
Comment 15 2012-05-14 11:13:51 PDT
Has this been further investigated? I was looking at eliminating more uses of sys.platform and came across this one.
Dirk Pranke
Comment 16 2012-05-14 12:13:27 PDT
Nope, I haven't had a chance to look into it further, and it's not super-high on my priority list.
Note You need to log in before you can comment on or make changes to this bug.