Bug 55073

Summary: [Chromium] Add WebKitClient::cryptographicallyRandomValues
Product: WebKit Reporter: Adam Barth <abarth>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch (will add ChangeLog before landing)
none
Patch
none
Patch none

Adam Barth
Reported 2011-02-23 12:47:07 PST
We need this to get random values into WTF while inside the sandbox.
Attachments
Patch (will add ChangeLog before landing) (651 bytes, patch)
2011-02-23 12:47 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.58 KB, patch)
2011-02-23 13:44 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.54 KB, patch)
2011-02-23 13:50 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-02-23 12:47:49 PST
Created attachment 83527 [details] Patch (will add ChangeLog before landing)
WebKit Review Bot
Comment 2 2011-02-23 12:54:18 PST
Attachment 83527 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7987213
Adam Barth
Comment 3 2011-02-23 13:44:14 PST
Created attachment 83540 [details] Patch
Darin Fisher (:fishd, Google)
Comment 4 2011-02-23 13:48:48 PST
Comment on attachment 83540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83540&action=review > Source/WebKit/chromium/public/WebKitClient.h:270 > + volatile char* nullPointer = 0; high there, please let me introduce you to my friend, WEBKIT_ASSERT_NOT_REACHED()
Adam Barth
Comment 5 2011-02-23 13:50:55 PST
Created attachment 83542 [details] Patch
Adam Barth
Comment 6 2011-02-23 14:08:40 PST
Committed r79487: <http://trac.webkit.org/changeset/79487>
Note You need to log in before you can comment on or make changes to this bug.