Bug 55059

Summary: WKBundleNavigationAction.h should be exposed as a public header
Product: WebKit Reporter: Mike Thole <mthole>
Component: WebKit2Assignee: Mike Thole <mthole>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.6   
Attachments:
Description Flags
Proposed patch darin: review+

Mike Thole
Reported 2011-02-23 10:44:05 PST
WKBundleNavigationAction.h should be exposed as a public header, so that it can be used in the injected bundle.
Attachments
Proposed patch (2.25 KB, patch)
2011-02-23 10:45 PST, Mike Thole 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Thole
Comment 1 2011-02-23 10:45:47 PST
Created attachment 83502 [details] Proposed patch
Darin Adler
Comment 2 2011-02-23 10:47:34 PST
Comment on attachment 83502 [details] Proposed patch Correct to change this from project. But I believe it should be private, not public, because WebKit2 is Mac OS X SPI, not API, at this time.
Mike Thole
Comment 3 2011-02-23 10:50:44 PST
Committed revision 79459.
Mike Thole
Comment 4 2011-02-23 10:54:09 PST
I left it as 'Public', which matches equivalent headers (e.g. WKBundleNodeHandle.h, WKBundlePage.h) in WK2. I think the system-level API vs. SPI issue is handled by putting all of WebKit2.framework in the /System/Library/PrivateFrameworks, rather than /System/Library/Frameworks.
WebKit Review Bot
Comment 5 2011-02-23 11:43:48 PST
http://trac.webkit.org/changeset/79459 might have broken Qt Linux Release The following tests are not passing: fast/overflow/overflow-height-float-not-removed-crash3.html
Note You need to log in before you can comment on or make changes to this bug.