Summary: | [Qt] MinGW build fails to link | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andras Becsi <abecsi> | ||||||||
Component: | Tools / Tests | Assignee: | Andras Becsi <abecsi> | ||||||||
Status: | RESOLVED DUPLICATE | ||||||||||
Severity: | Blocker | CC: | jturcotte, laszlo.gombos, ossy | ||||||||
Priority: | P1 | Keywords: | Qt, QtTriaged | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 50251 | ||||||||||
Attachments: |
|
Description
Andras Becsi
2011-02-23 08:35:32 PST
This documentation says: http://www.network-theory.co.uk/docs/gccintro/gccintro_18.html "Most current linkers will search all libraries, regardless of order, but since some do not do this it is best to follow the convention of ordering libraries from left to right." The problem win-gcc has is that the webcore and jscore libraries are after the windows libraries in the build command line, so there are unresolved symbols. Created attachment 83488 [details]
proposed patch
I don't set r?, so Laszlo can check whether it works on Symbian, Ossy already shut down our Windows bots.
Created attachment 83490 [details]
proposed patch
Fix the final linking order to be webkit2 webcore jscore.
(In reply to comment #3) > Created an attachment (id=83490) [details] > proposed patch > > Fix the final linking order to be webkit2 webcore jscore. No regression on Symbian build from this patch. Patch looks good to me, please put it up for review. Comment on attachment 83490 [details]
proposed patch
Thanks, Laszlo, for checking.
Comment on attachment 83490 [details]
proposed patch
Looks good to me, r+.
Landed in http://trac.webkit.org/changeset/79548. Closing bug. Comment on attachment 83490 [details]
proposed patch
Clearing flags.
Reopen, because it still fails with MinGW on Windows. (But works with cross-MinGW on Linux - with same MinGW version) Created attachment 86626 [details]
build log for linking
I prefer to close this as DUP as the other bug was opened earlier for MingW on Windows (even though that bug has a higher bug id). There is also some good progress on resolving this on the other bug. *** This bug has been marked as a duplicate of bug 56723 *** |