Summary: | IndexedDB: Each layout test should use a separate DB | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hans Wennborg <hans> | ||||
Component: | New Bugs | Assignee: | Hans Wennborg <hans> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andreip, commit-queue, dgrogan, jorlow | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Hans Wennborg
2011-02-23 06:08:00 PST
Created attachment 83478 [details]
Patch
This morning saw some changes that made IndexedDB tests fail, seemingly because the tests got run in parallel. If we let each test use its own database, this shouldn't be a problem. (This was on my Linux box after http://trac.webkit.org/changeset/79424 landed, and it went away if I ran the tests with --worker-model=old-threads. It doesn't seem to affect the bots(?), but I think we should fix it anyway.) Please review. Comment on attachment 83478 [details]
Patch
r=me
feel free to land yourself, but cq just in case it beats you
David/Andrei: please follow this naming scheme from now on The commit-queue encountered the following flaky tests while processing attachment 83478 [details]: inspector/elements/insert-node-collapsed.html bug 55058 (author: pfeldman@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 83478 [details] Patch Clearing flags on attachment: 83478 Committed r79458: <http://trac.webkit.org/changeset/79458> All reviewed patches have been landed. Closing bug. |