Bug 55029

Summary: [Qt] tst_QWebView::setPalette(activeFG) fails
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Critical CC: commit-queue, kling, menard
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 31742    
Attachments:
Description Flags
Patch to improve the auto-test. none

Description Csaba Osztrogonác 2011-02-23 03:17:14 PST 
FAIL!  : tst_QWebView::setPalette(activeBG) 'img1 != img2' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp(426)]

FAIL!  : tst_QWebView::setPalette(activeFG) 'img1 != img2' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp(426)]
Comment 1 Alexis Menard (darktears) 2011-02-23 03:23:47 PST 
It's not a regression, the tests were added with the patch :).
Comment 2 Csaba Osztrogonác 2011-02-23 03:25:22 PST 
(In reply to comment #1)
> It's not a regression, the tests were added with the patch :).

OK, it's not a regression. :) But tests introduced in r79409 still fail.
Comment 3 Alexis Menard (darktears) 2011-02-23 03:29:37 PST 
But I'm on it :)
Comment 4 Csaba Osztrogonác 2011-02-23 03:30:57 PST 
(In reply to comment #3)
> But I'm on it :)

Cool, thanks. ;)
Comment 5 Alexis Menard (darktears) 2011-02-23 09:37:40 PST 
Created attachment 83491 [details]
Patch to improve the auto-test.
Comment 6 Ariya Hidayat 2011-02-23 10:45:00 PST 
Comment on attachment 83491 [details]
Patch to improve the auto-test.

LGTM. re=me.
Comment 7 WebKit Commit Bot 2011-02-23 11:03:50 PST 
Comment on attachment 83491 [details]
Patch to improve the auto-test.

Clearing flags on attachment: 83491

Committed r79463: <http://trac.webkit.org/changeset/79463>
Comment 8 WebKit Commit Bot 2011-02-23 11:03:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Andreas Kling 2011-02-24 05:44:43 PST 
Committed r79552: <http://trac.webkit.org/changeset/79552>