Bug 55020

Summary: Add missing files to JavaScriptCore.gypi
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, morrita, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 55043    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch
none
Patch ojan: review+

Description Adam Barth 2011-02-22 21:02:12 PST
Add missing files to JavaScriptCore.gypi
Comment 1 Adam Barth 2011-02-22 21:03:38 PST
Created attachment 83438 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-02-22 21:05:08 PST
Comment on attachment 83438 [details]
Patch

OK (so long as this doesn't break the chromium build -- which is careful to only include stuff in wtf).
Comment 3 WebKit Review Bot 2011-02-22 21:07:45 PST
Attachment 83438 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7983002
Comment 4 Adam Barth 2011-02-22 21:08:53 PST
Sigh.
Comment 5 Adam Barth 2011-02-22 21:14:24 PST
Created attachment 83439 [details]
Patch
Comment 6 WebKit Review Bot 2011-02-22 21:20:58 PST
Attachment 83439 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7983004
Comment 7 WebKit Review Bot 2011-02-22 23:58:34 PST
Attachment 83439 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7986031
Comment 8 Adam Barth 2011-02-23 00:59:31 PST
Committed r79418: <http://trac.webkit.org/changeset/79418>
Comment 9 Hajime Morrita 2011-02-23 06:01:49 PST
This change breaks Linux shlib build.
http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg-shlib%29/builds/8194
Anyway just for curious, why the list contains brew and android files?
Are they intend to be filtered out?
Comment 10 Eric Seidel (no email) 2011-02-23 12:49:42 PST
Yes. My understanding of how the gyp build is designed is that we have one single list of files. All the ports are then responsble for filtering that list down to what they actually want to build.
Comment 11 Adam Barth 2011-02-23 23:57:09 PST
Committed r79519: <http://trac.webkit.org/changeset/79519>