Bug 54996

Summary:

[Qt] [WK2] When the context menu is empty, we should still send the signal QWKPage::showContextMenu()

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebKit2

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

commit-queue

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2011-02-22 13:54:44 PST

Currently, the signal QWKPage::showContextMenu() is sent only if the context menu is not empty. This can be a problem for users who want to extend the context menu because they get no notification in that case.

The signal should be sent in any case, with an empty menu if necessary.

Comment 1 Benjamin Poulain 2011-02-22 14:19:17 PST

Created attachment 83387 [details]
Patch

Comment 2 Andreas Kling 2011-02-22 14:22:55 PST

Comment on attachment 83387 [details]
Patch

Haia!

Comment 3 WebKit Commit Bot 2011-02-23 01:11:35 PST

Comment on attachment 83387 [details]
Patch

Clearing flags on attachment: 83387

Committed r79421: <http://trac.webkit.org/changeset/79421>

Comment 4 WebKit Commit Bot 2011-02-23 01:11:40 PST

All reviewed patches have been landed.  Closing bug.