Bug 54992

Summary: Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: New BugsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
ap: review+
Patch none

Patrick R. Gansterer
Reported 2011-02-22 13:39:51 PST
Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
Attachments
Patch (7.04 KB, patch)
2011-02-22 13:40 PST, Patrick R. Gansterer 		ap: review+
DetailsFormatted DiffDiff
Patch (11.62 KB, patch)
2011-02-23 03:41 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-02-22 13:40:53 PST
Created attachment 83376 [details] Patch
Alexey Proskuryakov
Comment 2 2011-02-22 17:20:22 PST
Comment on attachment 83376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83376&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:2826 > + priv->page_settings->setStandardFontFamily(WTF::AtomicString::fromUTF8(family)); Why WTF::AtomicString? > Source/WebKit/efl/ewk/ewk_view.cpp:2842 > + priv->page_settings->setCursiveFontFamily(WTF::AtomicString::fromUTF8(family)); Ditto. > Source/WebKit/efl/ewk/ewk_view.cpp:2858 > + priv->page_settings->setFantasyFontFamily(WTF::AtomicString::fromUTF8(family)); Ditto. > Source/WebKit/efl/ewk/ewk_view.cpp:2874 > + priv->page_settings->setFixedFontFamily(WTF::AtomicString::fromUTF8(family)); Ditto. > Source/WebKit/efl/ewk/ewk_view.cpp:2890 > + priv->page_settings->setSerifFontFamily(WTF::AtomicString::fromUTF8(family)); Ditto. > Source/WebKit/efl/ewk/ewk_view.cpp:3027 > + priv->page_settings->setLocalStorageDatabasePath(WTF::String::fromUTF8(path)); Ditto.
Patrick R. Gansterer
Comment 3 2011-02-23 03:41:05 PST
Created attachment 83465 [details] Patch (In reply to comment #2) > > Source/WebKit/efl/ewk/ewk_view.cpp:2826 > > + priv->page_settings->setStandardFontFamily(WTF::AtomicString::fromUTF8(family)); > > Why WTF::AtomicString? Good catch.
WebKit Commit Bot
Comment 4 2011-02-23 06:05:51 PST
Comment on attachment 83465 [details] Patch Clearing flags on attachment: 83465 Committed r79441: <http://trac.webkit.org/changeset/79441>
WebKit Commit Bot
Comment 5 2011-02-23 06:05:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.