Bug 54952

Summary:

Cleaning: remove a overzealous check for the pointer "files" from Chrome::setToolTip()

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebKit Misc.

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

ap, commit-queue

Priority:

Keywords:

EasyFix

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Benjamin Poulain

Reported 2011-02-22 06:18:44 PST

In the following code if (input->isFileUpload()) { FileList* files = input->files(); unsigned listSize = files->length(); if (files && listSize > 1) { The pointer "files" always exists if isFileUpload(). Moreover, the check is done after deferencing the pointer anyway. Fix that :)

Attachments
Patch (1.55 KB, patch) 2011-02-22 06:22 PST, Benjamin Poulain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2011-02-22 06:22:19 PST

Created attachment 83305 [details] Patch

WebKit Commit Bot

Comment 2 2011-02-22 06:50:07 PST

Comment on attachment 83305 [details] Patch Clearing flags on attachment: 83305 Committed r79317: <http://trac.webkit.org/changeset/79317>

WebKit Commit Bot

Comment 3 2011-02-22 06:50:12 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.