Bug 54951

Summary: Web Inspector: Timeline agent should have same lifetime as InspectorAgent
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 54112    
Attachments:
Description Flags
Patch
pfeldman: review+
Patch that I'm going to land none

Yury Semikhatsky
Reported 2011-02-22 06:07:44 PST
Web Inspector: Timeline agent should have same lifetime as InspectorAgent
Attachments
Patch (23.65 KB, patch)
2011-02-22 06:11 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Patch that I'm going to land (22.15 KB, application/octet-stream)
2011-02-22 07:23 PST, Yury Semikhatsky 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-02-22 06:11:28 PST
Created attachment 83304 [details] Patch
Pavel Feldman
Comment 2 2011-02-22 06:28:43 PST
Comment on attachment 83304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83304&action=review > LayoutTests/inspector/timeline/timeline-network-resource.html:21 > + TimelineAgent.startTimelineProfiler(step1); TimelineAgent.start() > LayoutTests/inspector/timeline/timeline-network-resource.html:31 > + TimelineAgent.stopTimelineProfiler(step3); .stop() > Source/WebCore/inspector/InspectorTimelineAgent.cpp:96 > +/* Comment?
Yury Semikhatsky
Comment 3 2011-02-22 07:23:55 PST
Created attachment 83310 [details] Patch that I'm going to land All comments were addressed.
Yury Semikhatsky
Comment 4 2011-02-22 07:33:09 PST
Committed r79323: <http://trac.webkit.org/changeset/79323>
Note You need to log in before you can comment on or make changes to this bug.