Bug 54939 – [Chromium] keycode is always 0 when using non-Latin keyboard layout.

• Component: Platform
• Status: RESOLVED FIXED

[James Su]

What steps will reproduce the problem?
1. Open http://unixpapa.com/js/testkey.html
2. Switch to a non-Latin keyboard layout, eg. Russian, Arabic.
3. Press some keys.

What is the expected output? What do you see instead?
keyCode value of key events should not be zero, but they are always zero when using non-Latin keyboard layout.

See: http://crbug.com/73119

[James Su]

Created attachment 83277 [details]
Patch to fix this issue.

[Dimitri Glazkov (Google)]

Avi, can you take a look?

[Avi Drissman]

(In reply to comment #2)
> Avi, can you take a look?

I like this. The original code was stolen from KeyEventMac, which was seriously cleaned up afterwards. We should match KeyEventMac.

[Eric Seidel (no email)]

Comment on attachment 83277 [details]
Patch to fix this issue.

Yay!  How do we test this?

[James Su]

(In reply to comment #4)
> (From update of attachment 83277 [details])
> Yay!  How do we test this?

I'm wondering if we could extend DumpRenderTree's keyDown method to support generating key event with arbitrary content, so that we could write layout tests as normal.

[James Su]

Can anybody help commit?

[James Su]

ping?

[WebKit Commit Bot]

Comment on attachment 83277 [details]
Patch to fix this issue.

Rejecting attachment 83277 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1

Last 500 characters of output:
ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'

Full output: http://queues.webkit.org/results/8085324

[WebKit Commit Bot]

Comment on attachment 83277 [details]
Patch to fix this issue.

Rejecting attachment 83277 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1

Last 500 characters of output:
ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'

Full output: http://queues.webkit.org/results/8087415

[James Su]

Can anyone help me look into this problem?

(In reply to comment #9)
> (From update of attachment 83277 [details])
> Rejecting attachment 83277 [details] from commit-queue.
> 
> Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1
> 
> Last 500 characters of output:
> ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
>     step(tool, options).run(state)
>   File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run
>     if self._has_valid_reviewer(changelog_entry):
>   File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer
>     if changelog_entry.reviewer():
> AttributeError: 'NoneType' object has no attribute 'reviewer'
> 
> Full output: http://queues.webkit.org/results/8087415

[Dimitri Glazkov (Google)]

Comment on attachment 83277 [details]
Patch to fix this issue.

The ChangeLog is malformed. Look at author's name. It should be in "Bob Foobar <[e-mail]>" format.

[James Su]

Created attachment 84683 [details]
Fix email address in ChangeLog files.

[James Su]

My fault. New patch uploaded, please have a look.

(In reply to comment #11)
> (From update of attachment 83277 [details])
> The ChangeLog is malformed. Look at author's name. It should be in "Bob Foobar <[e-mail]>" format.

[Dimitri Glazkov (Google)]

Comment on attachment 84683 [details]
Fix email address in ChangeLog files.

all systems go.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 84683 [details]:

inspector/timeline/timeline-network-resource.html bug 55751 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 84683 [details]
Fix email address in ChangeLog files.

Clearing flags on attachment: 84683

Committed r80336: <http://trac.webkit.org/changeset/80336>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.