Summary: | [Chromium] keycode is always 0 when using non-Latin keyboard layout. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Su <suzhe> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | avi, commit-queue, dglazkov | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | OS X 10.6 | ||||||||
URL: | http://unixpapa.com/js/testkey.html | ||||||||
Attachments: |
|
Description
James Su
2011-02-21 23:28:55 PST
Created attachment 83277 [details]
Patch to fix this issue.
Avi, can you take a look? (In reply to comment #2) > Avi, can you take a look? I like this. The original code was stolen from KeyEventMac, which was seriously cleaned up afterwards. We should match KeyEventMac. Comment on attachment 83277 [details]
Patch to fix this issue.
Yay! How do we test this?
(In reply to comment #4) > (From update of attachment 83277 [details]) > Yay! How do we test this? I'm wondering if we could extend DumpRenderTree's keyDown method to support generating key event with arbitrary content, so that we could write layout tests as normal. Can anybody help commit? ping? Comment on attachment 83277 [details] Patch to fix this issue. Rejecting attachment 83277 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1 Last 500 characters of output: ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run if self._has_valid_reviewer(changelog_entry): File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' Full output: http://queues.webkit.org/results/8085324 Comment on attachment 83277 [details] Patch to fix this issue. Rejecting attachment 83277 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1 Last 500 characters of output: ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run if self._has_valid_reviewer(changelog_entry): File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' Full output: http://queues.webkit.org/results/8087415 Can anyone help me look into this problem? (In reply to comment #9) > (From update of attachment 83277 [details]) > Rejecting attachment 83277 [details] from commit-queue. > > Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1 > > Last 500 characters of output: > ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run > step(tool, options).run(state) > File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run > if self._has_valid_reviewer(changelog_entry): > File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer > if changelog_entry.reviewer(): > AttributeError: 'NoneType' object has no attribute 'reviewer' > > Full output: http://queues.webkit.org/results/8087415 Comment on attachment 83277 [details] Patch to fix this issue. The ChangeLog is malformed. Look at author's name. It should be in "Bob Foobar <bob@foobar.baz>" format. Created attachment 84683 [details]
Fix email address in ChangeLog files.
My fault. New patch uploaded, please have a look. (In reply to comment #11) > (From update of attachment 83277 [details]) > The ChangeLog is malformed. Look at author's name. It should be in "Bob Foobar <bob@foobar.baz>" format. Comment on attachment 84683 [details]
Fix email address in ChangeLog files.
all systems go.
The commit-queue encountered the following flaky tests while processing attachment 84683 [details]: inspector/timeline/timeline-network-resource.html bug 55751 (authors: loislo@chromium.org, pfeldman@chromium.org, and yurys@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 84683 [details] Fix email address in ChangeLog files. Clearing flags on attachment: 84683 Committed r80336: <http://trac.webkit.org/changeset/80336> All reviewed patches have been landed. Closing bug. |