Bug 54925

Summary: nrwt: revert behavior on 10.5 to "old-threads"
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, atwilson, jamesr, ojan, rniwa, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch tkent: review+

Dirk Pranke
Reported 2011-02-21 18:54:49 PST
nrwt: revert behavior on 10.5 to "old-threads"
Attachments
Patch (5.12 KB, patch)
2011-02-21 19:01 PST, Dirk Pranke 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-02-21 19:01:48 PST
Created attachment 83255 [details] Patch
Dirk Pranke
Comment 2 2011-02-21 19:06:38 PST
Someone wanna rubber-stamp this partial revert of r79062 ? http://trac.webkit.org/changeset/79062 I can't explain why we'd see increased flakiness on 10.5, since we're still only running one DRT at a time, just in a different code path. I'm curious to see if changing things back to the old method does remove the flakiness and timeouts. 10.6 should be unaffected by this patch and continue to run in parallel processes by default.
Kent Tamura
Comment 3 2011-02-21 19:18:00 PST
Comment on attachment 83255 [details] Patch Though I'm not so familiar with NRWT code, it's ok to do partial revert.
Dirk Pranke
Comment 4 2011-02-21 19:31:46 PST
Committed r79279: <http://trac.webkit.org/changeset/79279>
Note You need to log in before you can comment on or make changes to this bug.