[GStreamer] GRefPtr support for GstElement

• Component: Media
• Status: RESOLVED FIXED

[Philippe Normand]

So in some places we could use GstElement smart pointer without explicitely calling gst_object_unref.

[Philippe Normand]

Created attachment 83148 [details]
proposed patch

[WebKit Review Bot]

Attachment 83148 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeListsEfl.txt', u'Sourc..." exit_code: 1

Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h:20:  #ifndef header guard has wrong style, please use: WTF_GRefPtrGStreamer_h  [build/header_guard] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Created attachment 83150 [details]
proposed patch

[Martin Robinson]

Comment on attachment 83150 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83150&action=review

> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:32
> +template <> void derefGPtr<GstElement>(GstElement* ptr)
> +{
> +    if (ptr)
> +        gst_object_unref(ptr);
> +}

There should also be a specialization for refGPtr even if it's currently unused with your changes. If that's not there g_object_ref will be used when you assign a GRefPtr.

[Philippe Normand]

Created attachment 83455 [details]
proposed patch

[Philippe Normand]

Committed r79546: <http://trac.webkit.org/changeset/79546>