| Summary: | [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | Tools / Tests | Assignee: | Alexis Menard (darktears) <menard> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Critical | CC: | commit-queue, kling, menard, mitz, mjs | ||||
| Priority: | P1 | Keywords: | Qt, QtTriaged | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Will most probably close that one : https://bugs.webkit.org/show_bug.cgi?id=50388 Got it. I make the patch. Created attachment 83486 [details]
Unbreak the resizing :)
Thanks for writing and testing the patch. Sorry for causing this regression. It's alright :). No worries was quite easy to understand the problem and write the fix just by looking at your patch. Thanks for the review. Comment on attachment 83486 [details] Unbreak the resizing :) Clearing flags on attachment: 83486 Committed r79450: <http://trac.webkit.org/changeset/79450> All reviewed patches have been landed. Closing bug. |
FAIL! : tst_QGraphicsWebView::widgetsRenderingThroughCache() Compared values are not the same Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(176)] FAIL! : tst_QWebElement::render() 'image3 == image4' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp(1014)] FAIL! : tst_QWebFrame::hitTestContent() Compared values are not the same Actual (result.linkText()): Expected (QString("link text")): link text Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(2688)]