Bug 54865

Summary: [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Critical CC: commit-queue, kling, menard, mitz, mjs
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Unbreak the resizing :) none

Csaba Osztrogonác
Reported 2011-02-21 02:31:34 PST
FAIL! : tst_QGraphicsWebView::widgetsRenderingThroughCache() Compared values are not the same Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(176)] FAIL! : tst_QWebElement::render() 'image3 == image4' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp(1014)] FAIL! : tst_QWebFrame::hitTestContent() Compared values are not the same Actual (result.linkText()): Expected (QString("link text")): link text Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(2688)]
Attachments
Unbreak the resizing :) (1.36 KB, patch)
2011-02-23 08:42 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-02-23 05:37:58 PST
Will most probably close that one : https://bugs.webkit.org/show_bug.cgi?id=50388
Alexis Menard (darktears)
Comment 2 2011-02-23 08:33:26 PST
Got it. I make the patch.
Alexis Menard (darktears)
Comment 3 2011-02-23 08:42:57 PST
Created attachment 83486 [details] Unbreak the resizing :)
mitz
Comment 4 2011-02-23 08:47:59 PST
Thanks for writing and testing the patch. Sorry for causing this regression.
Alexis Menard (darktears)
Comment 5 2011-02-23 08:52:33 PST
It's alright :). No worries was quite easy to understand the problem and write the fix just by looking at your patch. Thanks for the review.
WebKit Commit Bot
Comment 6 2011-02-23 09:07:46 PST
Comment on attachment 83486 [details] Unbreak the resizing :) Clearing flags on attachment: 83486 Committed r79450: <http://trac.webkit.org/changeset/79450>
WebKit Commit Bot
Comment 7 2011-02-23 09:07:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.