Bug 54857

Summary: [EFL] limit touch events when only page required touch events.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, benjamin, commit-queue, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ryuan Choi
Reported 2011-02-21 00:21:03 PST
ChromeClient have an api, needsTouchEvents, which tell the platform to stop forwarding touch events to WebCore. So, We'd better to block ewk_frame_feed_touch_event when needsTouchEvents got false.
Attachments
Patch (4.14 KB, patch)
2011-02-21 16:43 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2011-02-21 21:50 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (4.33 KB, patch)
2011-02-24 16:51 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-02-21 16:43:20 PST
Created attachment 83240 [details] Patch
Ryuan Choi
Comment 2 2011-02-21 21:50:30 PST
Created attachment 83269 [details] Patch
Ryuan Choi
Comment 3 2011-02-21 21:52:55 PST
(In reply to comment #2) > Created an attachment (id=83269) [details] > Patch Additionally fix possible leak when just returning.
Eric Seidel (no email)
Comment 4 2011-02-24 03:13:05 PST
Comment on attachment 83269 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83269&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:98 > + Eina_Bool needs_of_touch_events:1; This isnt' english.
Ryuan Choi
Comment 5 2011-02-24 16:51:30 PST
Created attachment 83749 [details] Patch
Ryuan Choi
Comment 6 2011-02-24 16:55:41 PST
(In reply to comment #4) > (From update of attachment 83269 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=83269&action=review > > > Source/WebKit/efl/ewk/ewk_view.cpp:98 > > + Eina_Bool needs_of_touch_events:1; > > This isnt' english. I changed variable and function name.
Kenneth Rohde Christiansen
Comment 7 2011-03-09 04:27:15 PST
Benjamin, this one seems up your alley!
WebKit Commit Bot
Comment 8 2011-03-10 15:23:17 PST
Comment on attachment 83749 [details] Patch Clearing flags on attachment: 83749 Committed r80771: <http://trac.webkit.org/changeset/80771>
WebKit Commit Bot
Comment 9 2011-03-10 15:23:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.