Bug 54853 – Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow

• Component: DOM
• Status: RESOLVED FIXED

[Roland Steiner]

Move the source files TextControlInnerElements.cpp/.h containing shadow DOM code for <input> elements from WebCore/rendering to WebCore/html/shadow as a first step in the larger refactoring of moving <input> to use the new shadow DOM approach.

(cf. https://bugs.webkit.org/show_bug.cgi?id=54179 et al)

[Roland Steiner]

Created attachment 83132 [details]
Patch

[Roland Steiner]

Created attachment 83133 [details]
patch - including moved files

Iiiinteresting - webkit-patch seems to have troubles with renamed/moved files. Uploading the full patch manually.

[WebKit Review Bot]

Attachment 83132 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7939695

[Early Warning System Bot]

Attachment 83132 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7940593

[Kent Tamura]

Comment on attachment 83133 [details]
patch - including moved files

View in context: https://bugs.webkit.org/attachment.cgi?id=83133&action=review

The patch will lose svn revision history.
Please make a patch in svn checkout.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22479
> +				14C0BC651312432C0030E8AB /* TextControlInnerElements.h in Headers */,

The file list should be sorted.
It's ok to run sort-Xcode-project-file after you commit this patch.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:25168
> +				14C0BC641312432C0030E8AB /* TextControlInnerElements.cpp in Sources */,

ditto.

[Roland Steiner]

Note: Except for moving I left the file and class names as-is, in order to minimize changes. However, I wonder if 'InputInnerElements' (or some such) wouldn't be a nice'n'shorter name.

[Roland Steiner]

Created attachment 83274 [details]
patch, from SVN checkout

[Kent Tamura]

Comment on attachment 83274 [details]
patch, from SVN checkout

>Index: Source/WebCore/html/shadow/TextControlInnerElements.cpp
>===================================================================
>--- Source/WebCore/html/shadow/TextControlInnerElements.cpp	(revision 79274)	(from Source/WebCore/rendering/TextControlInnerElements.cpp:79274)
>+++ Source/WebCore/html/shadow/TextControlInnerElements.cpp	(working copy)
>@@ -0,0 +1,535 @@

Did you run "svn mv"?
The patch seems still wrong. If you operate correctly, this should be a diff from rendering/TextControlInnerElements.cpp to shadow/TextControlInnerElements.cpp.

[Build Bot]

Attachment 83274 [details] did not build on win:
Build output: http://queues.webkit.org/results/7948033

[Kent Tamura]

(In reply to comment #8)
> (From update of attachment 83274 [details])
> >Index: Source/WebCore/html/shadow/TextControlInnerElements.cpp
> >===================================================================
> >--- Source/WebCore/html/shadow/TextControlInnerElements.cpp	(revision 79274)	(from Source/WebCore/rendering/TextControlInnerElements.cpp:79274)
> >+++ Source/WebCore/html/shadow/TextControlInnerElements.cpp	(working copy)
> >@@ -0,0 +1,535 @@
> 
> Did you run "svn mv"?
> The patch seems still wrong. If you operate correctly, this should be a diff from rendering/TextControlInnerElements.cpp to shadow/TextControlInnerElements.cpp.

I'm sorry, I was wrong.  This block contains "(from Source/WebCore/rendering/TextControlInnerElements.cpp)".  So it's ok.

Anyway, this patch has a problem on WebCore.vcproj.

[Roland Steiner]

Created attachment 83284 [details]
patch, SVN, fixes

Fixed Win. Also removed headers again from WebCore.pro to see if that pacifies the Qt buildbot (but interestingly it didn't seem fazed with the manual patch...)

[Kent Tamura]

Comment on attachment 83284 [details]
patch, SVN, fixes

ok

[Roland Steiner]

Committed r79978: <http://trac.webkit.org/changeset/79978>

[Ryosuke Niwa]

Comment on attachment 83284 [details]
patch, SVN, fixes

Clearing cq?