Summary: | Make WinCE a core builder | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
Component: | New Bugs | Assignee: | Patrick R. Gansterer <paroga> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, wsiegrist | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Patrick R. Gansterer
2011-02-19 04:29:37 PST
Created attachment 83070 [details]
Patch
Most of the people don't care about non-core builders, so make WinCE one. WinCE was only red, when people broke it. I didn't see any problem with the machine since it's online. Comment on attachment 83070 [details]
Patch
r=me, let's see how this goes! :)
Comment on attachment 83070 [details] Patch Clearing flags on attachment: 83070 Committed r79120: <http://trac.webkit.org/changeset/79120> All reviewed patches have been landed. Closing bug. Scrolling back though the history of <http://build.webkit.org/builders/WinCE%20Release%20%28Build%29> this morning, the builder appears to be red more often than its green. We'd like core builders to be green much more often than they're red. Hopefully the builder will remain green in the future. (In reply to comment #6) > Scrolling back though the history of <http://build.webkit.org/builders/WinCE%20Release%20%28Build%29> this morning, the builder appears to be red more often than its green. We'd like core builders to be green much more often than they're red. Hopefully the builder will remain green in the future. I've been one week on vacation and didn't fixed the build problems. That's also the reason why I didn't created this patch earlier. IMHO the problem is that most of the people don't care about non core builder. Ok. My point is more that being a core builder is descriptive rather than proscriptive. They're not intended to force people to care about a particular builder. They're intended to describe which builders people care about. In any case, it's purely an empirical list. If the builder remains green, no problem. If the builder is often red, then we can remove it from the list. Note: You'll need to ask wms to restart the buildbot master so that the bot shows up on the core builder page. (In reply to comment #8) > Ok. My point is more that being a core builder is descriptive rather than proscriptive. They're not intended to force people to care about a particular builder. They're intended to describe which builders people care about. When you get responses like "ohh, WinCE has a buildbot?", it seams to me that many people don't know about working non core builder. See also the "At times, people have mentioned to me that they left a failure in only because the bot is non-core and they didn't notice." from mjs in https://lists.webkit.org/pipermail/webkit-dev/2011-February/015894.html > In any case, it's purely an empirical list. If the builder remains green, no problem. If the builder is often red, then we can remove it from the list. So let's try it. :-) > So let's try it. :-)
Yep. :)
Buildbot master updated. |