Bug 54790

Summary: webkitpy.common.system.executive_unittest.ExecutiveTest.test_kill_all fails on Chromium Win Release Tests bot
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, aroben, dglazkov, eric, ojan, roger_fong, schenney, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
URL: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/9708/steps/webkitpy-test/logs/stdio
See Also: https://bugs.webkit.org/show_bug.cgi?id=155367
Bug Depends on:    
Bug Blocks: 48728, 57724    
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2011-02-18 19:22:14 PST
Attaching a build log. I don't know why this test is failing; it passes for me locally. It's possible there's some sort of timing difference on the bot and we're triggering a different code path in subprocess.wait(). If we don't have an obvious explanation for this failing, I'm tempted to skip it for now to green up the python tests on win32. Thoughts?
Attachments
Patch (2.69 KB, patch)
2011-02-28 17:39 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-02-28 17:06:14 PST
disabling this test for now to (hopefully) green up the builder.
Dirk Pranke
Comment 2 2011-02-28 17:39:58 PST
Created attachment 84162 [details] Patch
Dirk Pranke
Comment 3 2011-02-28 18:34:44 PST
anyone have any ideas before I disable it?
Dirk Pranke
Comment 4 2011-03-01 15:20:10 PST
Committed r80048: <http://trac.webkit.org/changeset/80048>
WebKit Review Bot
Comment 5 2011-03-01 16:33:04 PST
http://trac.webkit.org/changeset/80048 might have broken Qt Linux Release The following tests are not passing: fast/canvas/canvas-strokePath-gradient-shadow.html
Dirk Pranke
Comment 6 2011-03-02 18:18:29 PST
Clearing ownership now that we've disabled the test, in case someone else wants to figure out why it's failing.
Roger Fong
Comment 7 2012-10-02 12:39:23 PDT
Hey Dirk, Not sure how much you remember about this problem but it seems to be happening on the Windows port too. Here is the failure: [167/1585] webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process failed: Traceback (most recent call last): File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/common/system/executive_unittest.py", line 167, in serial_test_kill_process self.assertEqual(process.wait(), expected_exit_code) AssertionError: -6 != -9 First of all it looks like the platform we use is "cygwin" not "win32". Second -6 is SIGABRT. It only fails on the bots... Do you have any ideas? Thanks!
Eric Seidel (no email)
Comment 8 2012-10-02 12:48:43 PDT
I suspect we just need to make the unittest more flexible for this case. it's very likely the CYGWIN just changed the exit code returned in this kill case.
Roger Fong
Comment 9 2012-10-02 12:51:03 PDT
(In reply to comment #8) > I suspect we just need to make the unittest more flexible for this case. it's very likely the CYGWIN just changed the exit code returned in this kill case. Think it's reasonable for me to just add an extra case for cygwin then?
Roger Fong
Comment 10 2012-10-02 12:51:46 PDT
ALthough it's a bit weird that it's changing it only on the bots and not when I run locally...
Eric Seidel (no email)
Comment 11 2012-10-02 12:53:28 PDT
Seems totally reasonable to me.
Stephen Chenney
Comment 12 2013-04-11 13:18:38 PDT
Test related bugs being marked WontFix. TestExpectations will contain bug if still relevant.
Note You need to log in before you can comment on or make changes to this bug.