Bug 54771

Summary: WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: WebKit2Assignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar, PlatformOnly
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
URL: http://jhepple.com/SampleMovies/AVI_to_MPEG-4.avi
Attachments:
Description Flags
Patch sam: review+

Jer Noble
Reported 2011-02-18 14:02:25 PST
Videos played in a media document don't display video (just audio) under WebKit2.
Attachments
Patch (3.07 KB, patch)
2011-02-18 14:21 PST, Jer Noble 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-02-18 14:02:48 PST
rdar://problem/8492085
Jer Noble
Comment 2 2011-02-18 14:21:41 PST
Created attachment 83007 [details] Patch
Sam Weinig
Comment 3 2011-02-18 19:29:00 PST
Comment on attachment 83007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83007&action=review > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1533 > // Also don't claim to support accelerated rendering when in the media document, as we will then render > // via QTMovieView which is already accelerated. > - return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil && !m_player->inMediaDocument(); > + return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil; The comment here seems incorrect now.
Jer Noble
Comment 4 2011-02-18 21:29:35 PST
(In reply to comment #3) > (From update of attachment 83007 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=83007&action=review > > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1533 > > // Also don't claim to support accelerated rendering when in the media document, as we will then render > > // via QTMovieView which is already accelerated. > > - return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil && !m_player->inMediaDocument(); > > + return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil; > > The comment here seems incorrect now. I'll delete it. Thanks!
Jer Noble
Comment 5 2011-02-21 15:51:43 PST
Committed r79259: <http://trac.webkit.org/changeset/79259>
Note You need to log in before you can comment on or make changes to this bug.