Bug 54767

Summary: Use hashing instead of linear search in the conservative pointer test
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 54775    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Geoffrey Garen
Reported 2011-02-18 13:05:59 PST
Use hashing instead of linear search in the conservative pointer test
Attachments
Patch (1.62 KB, patch)
2011-02-18 13:07 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2011-02-18 16:49 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (3.20 KB, patch)
2011-02-18 17:06 PST, Geoffrey Garen 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-02-18 13:07:17 PST
Created attachment 83000 [details] Patch
Geoffrey Garen
Comment 2 2011-02-18 13:10:19 PST
Committed r79022: <http://trac.webkit.org/changeset/79022>
Csaba Osztrogonác
Comment 3 2011-02-18 14:27:13 PST
It seems this patch broke many tests on the Qt bot: http://build.webkit.org/results/Qt%20Linux%20Release/r79022%20%2828536%29/results.html Could you check it please?
Geoffrey Garen
Comment 5 2011-02-18 16:49:47 PST
Created attachment 83034 [details] Patch
Geoffrey Garen
Comment 6 2011-02-18 16:50:25 PST
The bug was a typo: always removing the last block from the set, instead of the block being freed.
Geoffrey Garen
Comment 7 2011-02-18 17:06:40 PST
Created attachment 83038 [details] Patch
Geoffrey Garen
Comment 8 2011-02-18 19:43:31 PST
Committed r79079: <http://trac.webkit.org/changeset/79079>
Note You need to log in before you can comment on or make changes to this bug.