Bug 54742

Summary: [Qt] The localized vendor name for Qt SIS packages should be "Nokia"
Product: WebKit Reporter: Ademar Reis <ademar>
Component: WebKit QtAssignee: Ademar Reis <ademar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, suresh.voruganti
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
patch
none
patch with better changelog none

Ademar Reis
Reported 2011-02-18 06:21:45 PST
From a commit in the Qt repository: """ The previously used name "Nokia, Qt" was not usable for Nokia Content Signing, which only allows "Nokia" as the visible vendor name. The unique vendor ID remains as "Nokia, Qt" """ This change was applied to Qt sources (qt/src/3rdparty/webkit, 4.7 branch), so we should do the same on QtWebKit. Patch is on the way.
Attachments
patch (1.78 KB, patch)
2011-02-18 06:24 PST, Ademar Reis 		no flags
DetailsFormatted DiffDiff
patch with better changelog (1.99 KB, patch)
2011-02-18 06:30 PST, Ademar Reis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ademar Reis
Comment 1 2011-02-18 06:24:12 PST
Created attachment 82950 [details] patch
Ademar Reis
Comment 2 2011-02-18 06:30:29 PST
Created attachment 82952 [details] patch with better changelog
WebKit Commit Bot
Comment 3 2011-02-18 19:38:42 PST
Comment on attachment 82952 [details] patch with better changelog Clearing flags on attachment: 82952 Committed r79077: <http://trac.webkit.org/changeset/79077>
WebKit Commit Bot
Comment 4 2011-02-18 19:38:47 PST
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 5 2011-02-21 05:48:57 PST
Revision r79077 cherry-picked into qtwebkit-2.0 with commit b564ef9 <http://gitorious.org/webkit/qtwebkit/commit/b564ef9>
Ademar Reis
Comment 6 2011-02-21 05:50:56 PST
Revision r79077 cherry-picked into qtwebkit-2.1 with commit f54b7ba <http://gitorious.org/webkit/qtwebkit/commit/f54b7ba>
Suresh Voruganti
Comment 7 2011-02-21 06:09:53 PST
(In reply to comment #6) > Revision r79077 cherry-picked into qtwebkit-2.1 with commit f54b7ba <http://gitorious.org/webkit/qtwebkit/commit/f54b7ba> Do we need to cherry pick the fix to Qtwebkit 2.1.x also?
Ademar Reis
Comment 8 2011-02-21 06:13:07 PST
(In reply to comment #7) > (In reply to comment #6) > > Revision r79077 cherry-picked into qtwebkit-2.1 with commit f54b7ba <http://gitorious.org/webkit/qtwebkit/commit/f54b7ba> > > Do we need to cherry pick the fix to Qtwebkit 2.1.x also? This is automatic: 2.1.x is constantly merged with 2.1 to make sure we have no regressions.
Note You need to log in before you can comment on or make changes to this bug.