Bug 54742

Summary: [Qt] The localized vendor name for Qt SIS packages should be "Nokia"
Product: WebKit Reporter: Ademar Reis <ademar>
Component: WebKit QtAssignee: Ademar Reis <ademar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, suresh.voruganti
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
patch
none
patch with better changelog none

Description Ademar Reis 2011-02-18 06:21:45 PST
From a commit in the Qt repository:

"""
    The previously used name "Nokia, Qt" was not usable for Nokia
    Content Signing, which only allows "Nokia" as the visible vendor
    name. The unique vendor ID remains as "Nokia, Qt"
"""

This change was applied to Qt sources (qt/src/3rdparty/webkit, 4.7 branch), so we should do the same on QtWebKit.

Patch is on the way.
Comment 1 Ademar Reis 2011-02-18 06:24:12 PST
Created attachment 82950 [details]
patch
Comment 2 Ademar Reis 2011-02-18 06:30:29 PST
Created attachment 82952 [details]
patch with better changelog
Comment 3 WebKit Commit Bot 2011-02-18 19:38:42 PST
Comment on attachment 82952 [details]
patch with better changelog

Clearing flags on attachment: 82952

Committed r79077: <http://trac.webkit.org/changeset/79077>
Comment 4 WebKit Commit Bot 2011-02-18 19:38:47 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Ademar Reis 2011-02-21 05:48:57 PST
Revision r79077 cherry-picked into qtwebkit-2.0 with commit b564ef9 <http://gitorious.org/webkit/qtwebkit/commit/b564ef9>
Comment 6 Ademar Reis 2011-02-21 05:50:56 PST
Revision r79077 cherry-picked into qtwebkit-2.1 with commit f54b7ba <http://gitorious.org/webkit/qtwebkit/commit/f54b7ba>
Comment 7 Suresh Voruganti 2011-02-21 06:09:53 PST
(In reply to comment #6)
> Revision r79077 cherry-picked into qtwebkit-2.1 with commit f54b7ba <http://gitorious.org/webkit/qtwebkit/commit/f54b7ba>

Do we need to cherry pick the fix to Qtwebkit 2.1.x also?
Comment 8 Ademar Reis 2011-02-21 06:13:07 PST
(In reply to comment #7)
> (In reply to comment #6)
> > Revision r79077 cherry-picked into qtwebkit-2.1 with commit f54b7ba <http://gitorious.org/webkit/qtwebkit/commit/f54b7ba>
> 
> Do we need to cherry pick the fix to Qtwebkit 2.1.x also?

This is automatic: 2.1.x is constantly merged with 2.1 to make sure we have no regressions.