Bug 54735
| Summary: | Should add a webkit-patch "try" command | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, mihaip |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=148899 | ||
Eric Seidel (no email)
Should add a webkit-patch "try" command
Would basically just be upload with --no-review and a pre-set title.
Would also automatically post the patch to queues.webkit.org/submit-to-ews w/o going through the r?
Seems it might pave the way for real try servers at some later date.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
Yeah, so it would be just:
webkit-patch upload --no-review -m "For EWS Bots"
I think it should also have some special text in the case where ChangeLogs are missing and thus it has to ask for a bug. Something like:
The Early Warning System depends on bugs.webkit.org to store patches for processing. If there is not already a bug for this patch, we will need to create one first. webkit-patch will walk you through the process, including creating a ChangeLog entry (which you'll eventually need for review anyway).
Bug number or title:
Ojan Vafai
This seems fine. Ideally we'd take bugzilla out of the picture though. We shouldn't need to bloat the bugs database in order to try a patch, not to mention that it sends an email.
Eric Seidel (no email)
Maybe. Bugzilla has worked very well for us so far as a storage and authentication system for us.