Bug 54726

Summary: use actual browser focus in the code review tool
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+

Ojan Vafai
Reported 2011-02-17 23:32:27 PST
use actual browser focus in the code review tool
Attachments
Patch (3.43 KB, patch)
2011-02-17 23:34 PST, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-02-17 23:34:20 PST
Created attachment 82927 [details] Patch
Adam Barth
Comment 2 2011-02-18 11:37:54 PST
Comment on attachment 82927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82927&action=review > Websites/bugs.webkit.org/code-review.js:1342 > + // Give a tabindex so the element can receive actual browser focus. > + // -1 makes the element focusable without actually putting in in the tab order. > + node.attr('tabindex', -1); Crazy!
Ojan Vafai
Comment 3 2011-02-20 18:29:32 PST
Committed r79163: <http://trac.webkit.org/changeset/79163>
Note You need to log in before you can comment on or make changes to this bug.