Bug 54712 – Make editing/selection/extend-selection tests more human readable and hand-runnable

• Component: New Bugs
• Status: RESOLVED FIXED

[Benjamin (Ben) Kalman]

Make editing/selection/extend-selection tests more human readable and hand-runnable

[Benjamin (Ben) Kalman]

Created attachment 82911 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 82911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82911&action=review

> LayoutTests/editing/selection/resources/extend-selection.js:196
> +            button.onmousedown = function(event) {
> +                event.preventDefault();
> +                event.stopPropagation();
> +            };

I don't quite get why you do this.

[Benjamin (Ben) Kalman]

Comment on attachment 82911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82911&action=review

>> LayoutTests/editing/selection/resources/extend-selection.js:196
>> +            };
> 
> I don't quite get why you do this.

it's to prevent clicking the button from cancelling the selection.
i've added a small comment.

[Benjamin (Ben) Kalman]

Created attachment 83109 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 83109 [details]
Patch for landing

Clearing flags on attachment: 83109

Committed r79160: <http://trac.webkit.org/changeset/79160>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.