Bug 54703

Summary: webkitpy.layout_tests.port.config_unittest fails on Win32
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 48728    
Attachments:
Description Flags
Patch aroben: review+

Dirk Pranke
Reported 2011-02-17 18:14:39 PST
webkitpy.layout_tests.port.config_unittest fails on Win32 because $HOME isn't defined.
Attachments
Patch (1.53 KB, patch)
2011-02-17 19:16 PST, Dirk Pranke 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-02-17 19:16:52 PST
Created attachment 82900 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-02-17 19:28:52 PST
Comment on attachment 82900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82900&action=review > Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py:195 > + if sys.platform == 'win32': > + os.chdir(os.environ['USERPROFILE']) > + else: > + os.chdir(os.environ['HOME']) I wonder if we should come up with our own abstraction for this? Maybe not if it's only needed by test code.
Dirk Pranke
Comment 3 2011-02-17 19:44:51 PST
(In reply to comment #2) > (From update of attachment 82900 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82900&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py:195 > > + if sys.platform == 'win32': > > + os.chdir(os.environ['USERPROFILE']) > > + else: > > + os.chdir(os.environ['HOME']) > > I wonder if we should come up with our own abstraction for this? Maybe not if it's only needed by test code. Yeah, I'd just as soon have it show up in at least two other places before we bother. Anyway, there's no significance to $HOME in this test, it's just known to be outside (or at least above) the tree.
Dirk Pranke
Comment 4 2011-02-18 15:39:44 PST
Committed r79042: <http://trac.webkit.org/changeset/79042>
Note You need to log in before you can comment on or make changes to this bug.