| Summary: | webkitpy.layout_tests.port.config_unittest fails on Win32 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
| Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, aroben, eric, ojan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 48728 | ||||||
| Attachments: |
|
||||||
|
Description
Dirk Pranke
2011-02-17 18:14:39 PST
Created attachment 82900 [details]
Patch
Comment on attachment 82900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82900&action=review > Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py:195 > + if sys.platform == 'win32': > + os.chdir(os.environ['USERPROFILE']) > + else: > + os.chdir(os.environ['HOME']) I wonder if we should come up with our own abstraction for this? Maybe not if it's only needed by test code. (In reply to comment #2) > (From update of attachment 82900 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82900&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py:195 > > + if sys.platform == 'win32': > > + os.chdir(os.environ['USERPROFILE']) > > + else: > > + os.chdir(os.environ['HOME']) > > I wonder if we should come up with our own abstraction for this? Maybe not if it's only needed by test code. Yeah, I'd just as soon have it show up in at least two other places before we bother. Anyway, there's no significance to $HOME in this test, it's just known to be outside (or at least above) the tree. Committed r79042: <http://trac.webkit.org/changeset/79042> |