Summary: | [v8] Change expectations for plugins/netscape-plugin-poperty-access-exception test | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | anton muhin <antonm> | ||||
Component: | WebCore Misc. | Assignee: | anton muhin <antonm> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, dglazkov, dpranke, morrita | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
anton muhin
2011-02-17 12:45:41 PST
Guys, sorry for shooting in the dark: I hope at least you can point out other people who can review this patch or ideally review it yourselves. I am fixing some issues with the way v8 process exceptions and that changes the way NPPlugins report exceptions. I hope my changes are ok---after all Safari, Chromium and FF apparently all behave differently. But if you have any concerns, I'd be happy to here and address them. Created attachment 82851 [details]
Patch
Sorry, I don't know much about these tests. It's too bad that everyone does something different... (In reply to comment #3) > Sorry, I don't know much about these tests. It's too bad that everyone does something different... With which I definitely agree. But I strongly suspect current Chromium's expectations just capture the erroneous behaviour of current v8's exception handling. Comment on attachment 82851 [details]
Patch
ok. I'm not super confident in this review, but it's probably ok.
Thanks a lot, Adam. I'll submit when v8 with my patch gets rolled. (In reply to comment #5) > (From update of attachment 82851 [details]) > ok. I'm not super confident in this review, but it's probably ok. Comment on attachment 82851 [details] Patch Clearing flags on attachment: 82851 Committed r83269: <http://trac.webkit.org/changeset/83269> All reviewed patches have been landed. Closing bug. |