Bug 54678

Summary: Web Inspector: get rid of InspectorInstrumentation::inspectorAgents() map
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Yury Semikhatsky
Reported 2011-02-17 12:02:14 PST
The agent can be retrieve from the corresponding InspectorController on the Page and there is no need in additional map. Also there is no page in case of worker threads.
Attachments
Patch (6.23 KB, patch)
2011-02-17 12:05 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (6.64 KB, patch)
2011-02-17 12:21 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (16.65 KB, patch)
2011-08-09 02:54 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-02-17 12:05:37 PST
Created attachment 82841 [details] Patch
WebKit Review Bot
Comment 2 2011-02-17 12:12:05 PST
Attachment 82841 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7920835
Yury Semikhatsky
Comment 3 2011-02-17 12:21:09 PST
Created attachment 82845 [details] Patch
Pavel Feldman
Comment 4 2011-02-17 22:11:00 PST
Comment on attachment 82845 [details] Patch I don't see why this change is necessary.
Yury Semikhatsky
Comment 5 2011-08-09 02:54:19 PDT
Created attachment 103340 [details] Patch
Pavel Feldman
Comment 6 2011-08-09 04:41:52 PDT
Comment on attachment 103340 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103340&action=review > Source/WebCore/inspector/InstrumentingAgents.h:171 > +InstrumentingAgents* instrumentationForWorkerContext(WorkerContext*); Looks good overall. It is not clear what the call sites are going to look like. Do you have a clue?
Yury Semikhatsky
Comment 7 2011-08-09 06:03:55 PDT
Committed r92677: <http://trac.webkit.org/changeset/92677>
Note You need to log in before you can comment on or make changes to this bug.