Bug 54678

Summary: Web Inspector: get rid of InspectorInstrumentation::inspectorAgents() map
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Description Yury Semikhatsky 2011-02-17 12:02:14 PST 
The agent can be retrieve from the corresponding InspectorController on the Page and there is no need in additional map. Also there is no page in case of worker threads.
Comment 1 Yury Semikhatsky 2011-02-17 12:05:37 PST 
Created attachment 82841 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-17 12:12:05 PST 
Attachment 82841 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7920835
Comment 3 Yury Semikhatsky 2011-02-17 12:21:09 PST 
Created attachment 82845 [details]
Patch
Comment 4 Pavel Feldman 2011-02-17 22:11:00 PST 
Comment on attachment 82845 [details]
Patch

I don't see why this change is necessary.
Comment 5 Yury Semikhatsky 2011-08-09 02:54:19 PDT 
Created attachment 103340 [details]
Patch
Comment 6 Pavel Feldman 2011-08-09 04:41:52 PDT 
Comment on attachment 103340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103340&action=review

> Source/WebCore/inspector/InstrumentingAgents.h:171
> +InstrumentingAgents* instrumentationForWorkerContext(WorkerContext*);

Looks good overall. It is not clear what the call sites are going to look like. Do you have a clue?
Comment 7 Yury Semikhatsky 2011-08-09 06:03:55 PDT 
Committed r92677: <http://trac.webkit.org/changeset/92677>