Summary: | Web Inspector: merge ConsoleView into ConsolePanel. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | apavlov, atwilson, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | 60958 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Pavel Podivilov
2011-02-17 09:47:19 PST
Created attachment 82824 [details]
Patch.
- Add ConsoleView functions to ConsolePanel
- ConsoleView class
- Rename ConsoleView.js to ConsoleMessage.js
Created attachment 82825 [details]
Diff between old ConsoleView and new ConsolePanel
Comment on attachment 82824 [details]
Patch.
Please provide diff with
git config
[diff]
renames = copies
Created attachment 91666 [details]
Patch.
No moves/renames, just make ConsoleView a panel.
Comment on attachment 91666 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=91666&action=review > Source/WebCore/ChangeLog:7 > + Please give a brief description of the changes made. It's not clear in particular how conversion of ConsoleView into a panel helps us to add implement snippet editor. > Source/WebCore/inspector/front-end/ConsoleView.js:32 > +WebInspector.ConsolePanel = function(drawer) Containing file should be renamed as well. > Source/WebCore/inspector/front-end/ConsoleView.js:248 > + this._previousConsoleState = WebInspector.drawer.state; This code should be removed from ConsolePanel.js, shouldn't it? > Source/WebCore/inspector/front-end/inspector.js:192 > + this.panels.console = this.console; This method is supposed to create panels. Created attachment 92238 [details]
Patch.
Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.
(In reply to comment #5) > (From update of attachment 91666 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91666&action=review > > > Source/WebCore/ChangeLog:7 > > + > > Please give a brief description of the changes made. It's not clear in particular how conversion of ConsoleView into a panel helps us to add implement snippet editor. Done. > > > Source/WebCore/inspector/front-end/ConsoleView.js:32 > > +WebInspector.ConsolePanel = function(drawer) > > Containing file should be renamed as well. > > > Source/WebCore/inspector/front-end/ConsoleView.js:248 > > + this._previousConsoleState = WebInspector.drawer.state; > > This code should be removed from ConsolePanel.js, shouldn't it? Let me do it in a follow up patch. > > > Source/WebCore/inspector/front-end/inspector.js:192 > > + this.panels.console = this.console; > > This method is supposed to create panels. Done. Committed r86589: <http://trac.webkit.org/changeset/86589> This seems to be breaking the chromium canary bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20-%20chromium.org&tests=http%2Ftests%2Finspector%2Fchange-iframe-src.html%2Chttp%2Ftests%2Finspector%2Fconsole-resource-errors.html%2Chttp%2Ftests%2Finspector%2Fresource-tree%2Fresource-tree-frame-add.html Reverted r86589 for reason: Broke Committed r86595: <http://trac.webkit.org/changeset/86595> Committed r86660: <http://trac.webkit.org/changeset/86660> |