Bug 54669

Summary:

IndexedDB: Populate indexes created for object stores with data

Product:

WebKit

Reporter:

Hans Wennborg <hans>

Component:

New Bugs

Assignee:

Hans Wennborg <hans>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andreip, dgrogan, jorlow

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	jorlow: review+

Description Hans Wennborg 2011-02-17 09:26:57 PST

IndexedDB: Populate indexes created for object stores with data

Comment 1 Hans Wennborg 2011-02-17 09:28:30 PST

Created attachment 82821 [details]
Patch

Comment 2 Jeremy Orlow 2011-02-17 09:50:23 PST

Comment on attachment 82821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82821&action=review

great stuff!

> Source/WebCore/storage/IDBIndexBackendImpl.h:-32
> -

Isnt  this space typical?

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:328
> +        if (!it->second->hasValidId())

Probably worth a comment

Comment 3 Hans Wennborg 2011-02-18 01:56:50 PST

Committed r78980: <http://trac.webkit.org/changeset/78980>