Bug 54650

Summary: check-webkit-style falsely complains about WebKitGTK+ public headers
Product: WebKit Reporter: Christian Dywan <christian>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: commit-queue, hamaji, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Christian Dywan 2011-02-17 06:50:47 PST 
Source/WebKit/gtk/webkit/webkitwebgroup.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit/gtk/webkit/webkitwebgroup.h:56:  WEBKIT_API should only appear in the chromium public directory.  [readability/webkit_api] [5]
Source/WebKit/gtk/webkit/webkitwebgroup.h:62:  The parameter name "web_group" adds no information, so it should be removed.  [readability/parameter_name] [5]

These are all false positives.
Comment 1 David Levin 2011-02-18 11:37:52 PST 
Created attachment 82987 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-02-18 12:41:12 PST 
Comment on attachment 82987 [details]
Patch

OK.
Comment 3 WebKit Commit Bot 2011-02-18 21:52:05 PST 
Comment on attachment 82987 [details]
Patch

Clearing flags on attachment: 82987

Committed r79095: <http://trac.webkit.org/changeset/79095>
Comment 4 WebKit Commit Bot 2011-02-18 21:52:09 PST 
All reviewed patches have been landed.  Closing bug.